Feature #11727: [PATCH] io.c (rb_gc_for_fd): wrapper for retrying FD creation

• Status: Closed
• Assignee: -
• Target version: -

[normalperson (Eric Wong)]

io.c (rb_gc_for_fd): wrapper for retrying FD creation

This simplifies callers and makes error handling more consistent
between our pipe, open, fdopen, and dup wrappers.

This adds missing ENOMEM handling as documented in the open(2),
pipe(2freebsd), and fdopen(3posix) manpages on my system.

We also avoid repeatedly accessing errno which is implemented
in TLS on GNU/Linux systems and more expensive to read than a
local variable.

We may export this in internal.h for ext/socket/* and dir.c, too.

Maybe "rb_ran_gc_for_fd" is a better name... Naming is hard :<

• Status changed from Open to Closed

Applied in changeset r52725.

---

io.c (rb_gc_for_fd): wrapper for retrying FD creation

This simplifies callers and makes error handling more consistent
between our pipe, open, fdopen, and dup wrappers.

This adds missing ENOMEM handling as documented in the open(2),
pipe(2freebsd), and fdopen(3posix) manpages on my system.

We also avoid repeatedly accessing errno which is implemented
in TLS on GNU/Linux systems and more expensive to read than a
local variable.

We may export this in internal.h for ext/socket/* and dir.c, too.

• io.c (rb_gc_for_fd): new helper function
  (ruby_dup): use rb_gc_for_fd
  (rb_sysopen): ditto
  (rb_fdopen): ditto
  (rb_pipe): ditto
  [ruby-core:71623] [Feature #11727]