Bug #14323: net/ftp: fix FrozenError in BufferedSocket

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 2.3: DONE, 2.4: DONE, 2.5: DONE

[normalperson (Eric Wong)]

net/ftp: fix FrozenError in BufferedSocket

I noticed this bug while working on something else with
RUBYOPT=-d on, existing test cases all passed with it.

Note: I use String.new because it is the local style, here,
I prefer +'' (or ''.b, for a future commit)

• lib/net/ftp.rb (BufferedSocket#read): use String.new
• test/net/ftp/test_buffered_socket.rb (test_read_nil): new test

• Status changed from Open to Closed

Applied in changeset trunk|r61639.

---

net/ftp: fix FrozenError in BufferedSocket

I noticed this bug while working on something else with
RUBYOPT=-d on, existing test cases all passed with it.

Note: I use String.new because it is the local style, here,
I prefer +'' (or ''.b, for a future commit)

• lib/net/ftp.rb (BufferedSocket#read): use String.new
• test/net/ftp/test_buffered_socket.rb (test_read_nil): new test
  [ruby-core:84675] [Bug #14323]

[naruse (Yui NARUSE)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE

ruby_2_5 r62425 merged revision(s) 61639.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE to 2.3: REQUIRED, 2.4: DONE, 2.5: DONE

ruby_2_4 r62867 merged revision(s) 61639.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.3: REQUIRED, 2.4: DONE, 2.5: DONE to 2.3: DONE, 2.4: DONE, 2.5: DONE

ruby_2_3 r62943 merged revision(s) 61639.