Project

General

Profile

Actions

Misc #14764

closed

[PATCH] vm_trace: remove rb_postponed_job_t->flags

Added by normalperson (Eric Wong) almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Assignee:
-
[ruby-core:87052]

Description

vm_trace: remove rb_postponed_job_t->flags

This field has been taking up space for 5 years and never used.
Save 8kb of memory on x86-64 for now.  If we ever care about
this flag, we'll simply re-add it.

No ABI or API compatibility changes.

* vm_trace.c (rb_postponed_job_struct): remove flags
  (postponed_job_register): comment out flags assignment

Seems trivial, will commit soon unless somebody decides to
start using this flag now (after 5 years).


Files

Updated by normalperson (Eric Wong) almost 6 years ago

Btw, 1000 slots for postponed jobs seems like overkill,
as does the use of atomics.

I think we can use a st_table with st_shift...
Hash key can be the func pointer, since this API deduplicates
calls based on function.

Updated by ko1 (Koichi Sasada) almost 6 years ago

no problem. st_table also seems good.

Updated by normalperson (Eric Wong) almost 6 years ago

wrote:

no problem. st_table also seems good.

OK, this uses st_table:
https://80x24.org/spew/20180516090720.9935-1-e@80x24.org/raw
(only lightly-tested)

Actions #4

Updated by normalperson (Eric Wong) almost 6 years ago

  • Status changed from Open to Closed

Applied in changeset trunk|r63450.


vm_trace: remove rb_postponed_job_t->flags

This field has been taking up space for 5 years and never used.
Save 8kb of memory on x86-64 for now. If we ever care about
this flag, we'll simply re-add it.

  • vm_trace.c (rb_postponed_job_struct): remove flags
    (postponed_job_register): comment out flags assignment
    [ruby-core:87052] [Misc #14764]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0