Project

General

Profile

Actions

Bug #14828

closed

syn 63583 fix for windows

Added by MSP-Greg (Greg L) almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.6.0dev (2018-06-05 trunk 63572) [x64-mingw32]
[ruby-core:87420]

Description

@normalperson (Eric Wong)

svn 63583 seems to have broken the mswin build, I have the same issue locally with MinGW. The methods set_winsize_setup and set_winsize_teardown are defined base on whether PTY is defined. It is not on windows.

The test test_set_winsize_console is run regardless of whether PTY exsists, and hence the 'NameError: undefined local variable or method' message.

Attached patch is one way to fix the issue.

Thanks, Greg


Files

63583_fix.patch (819 Bytes) 63583_fix.patch MSP-Greg (Greg L), 06/06/2018 12:35 AM
Actions #1

Updated by normalperson (Eric Wong) almost 6 years ago

  • Status changed from Open to Closed

Applied in changeset trunk|r63585.


test/io/console/test_io_console.rb: fix for systems where PTY is not defined

[ruby-core:87420] [Bug #14828]
Thanks-to: MSP-Greg (Greg L)

Updated by normalperson (Eric Wong) almost 6 years ago

wrote:

https://bugs.ruby-lang.org/issues/14828

Thanks for the report. I moved the methods to be defined
globally in all cases, instead: r63585

Actions

Also available in: Atom PDF

Like0
Like0Like0