Project

General

Profile

Actions

Bug #16854

closed

Using (...) when the method name is a keyword generates error

Added by jamesnakagawa (James Nakagawa) almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:98323]

Description

Although I wouldn't generally recommend it, naming a method true is allowed. However, in combination with the new argument forwarding keyword ..., a syntax error is generated which does not occur with other argument choices.

This came up for me on my Rails project where an enumerated database column was defined to allow the values :true, :false (not an unreasonable request in itself). Active Record's generated class tried to contain methods by these names.

Try this code for yourself:

class Works
  def true(*args)
    puts(*args)
  end
end

Works.new.true 1, 2, 3
# => 1, 2, 3

class WontWork
  def true(...)
    puts(...)
  end
end

# => freezes

Updated by shevegen (Robert A. Heiler) almost 4 years ago

Interesting find and explanation.

Actions #3

Updated by nobu (Nobuyoshi Nakada) almost 4 years ago

  • Status changed from Open to Closed

Applied in changeset git|71c166e11e761dcaaa943f9b94da38f86ada1bdb.


Fixed argument forwarding in reserved word method [Bug #16854]

Actions #4

Updated by nobu (Nobuyoshi Nakada) almost 4 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN to 2.5: DONTNEED, 2.6: DONTNEED, 2.7: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

  • Backport changed from 2.5: DONTNEED, 2.6: DONTNEED, 2.7: REQUIRED to 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONE

ruby_2_7 be359442cb07c25fdc769431ffed3249b9016829 merged revision(s) 71c166e11e761dcaaa943f9b94da38f86ada1bdb.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0