Project

General

Profile

Actions

Bug #17532

closed

Remove `"` from `regstr` arguments in `vm_dump.c`

Added by xtkoba (Tee KOBAYASHI) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [aarch64-linux]
[ruby-core:102045]

Description

On AArch64 Linux, a machine register dump is printed as follows:

-- Machine register context ------------------------------------------------
 "x0: 0x0000000000000000 "x1: 0x000000000000000b "x2: 0x0000000000000000
 "x3: 0x5345475600000000 "x4: 0x0000000000000000 "x5: 0x5345475600000000
 "x6: 0x000000000108e600 "x7: 0x000000000000f00f "x1: 0x0000000000000000
 "x1: 0x000000000000000b "x2: 0x0000005501286080 "x2: 0x0000000000003020
 "x2: 0x0000000000000002 "x2: 0x0000000000000001 "x2: 0x0000000000000001
 "x2: 0x0000000000000001 "x2: 0x0000005500b85264 "x2: 0x0000005500b8518c
 "x2: 0x0000000000080b90 "x2: 0x00000055007fea30 "sp: 0x00000055007fe970
 "fa: 0x0000000000000000

As you can see above, the register names are indistinguishable. For example, there are 11 registers labeled "x2.

It should be printed as follows:

-- Machine register context ------------------------------------------------
  x0: 0x0000000000000000  x1: 0x000000000000000b  x2: 0x0000000000000000
  x3: 0x5345475600000000  x4: 0x0000000000000000  x5: 0x5345475600000000
  x6: 0x000000000108e600  x7: 0x000000000000f00f x18: 0x0000000000000000
 x19: 0x000000000000000b x20: 0x0000005501286080 x21: 0x0000000000003284
 x22: 0x0000000000000002 x23: 0x0000000000000001 x24: 0x0000000000000001
 x25: 0x0000000000000001 x26: 0x0000005500b85264 x27: 0x0000005500b8518c
 x28: 0x0000000000080b90 x29: 0x00000055007fea30  sp: 0x00000055007fe970
 fau: 0x0000000000000000

The same goes for ARM Linux.


Files

ruby-vm_dump-arm-regstr.patch (3.37 KB) ruby-vm_dump-arm-regstr.patch xtkoba (Tee KOBAYASHI), 01/13/2021 02:12 AM
Actions #1

Updated by nobu (Nobuyoshi Nakada) over 3 years ago

  • Status changed from Open to Closed

Applied in changeset git|d8fb0bca5475d62731ba871adf344fef88f62bbf.


Removed excess stringizations on regstr [Bug #17532]

Actions

Also available in: Atom PDF

Like0
Like0