Bug #3866

Multipart Form Parsing bug

Added by engwan (Heinrich Lee Yu) over 1 year ago. Updated 11 months ago.

[ruby-core:32510]
Status:Closed Start date:09/23/2010
Priority:Normal Due date:
Assignee:xibbar (Takeyuki Fujioka) % Done:

100%

Category:lib
Target version:1.9.3
ruby -v:Ruby 1.9.2p0

Description

Ruby 1.9.2p0 seems to have a problem similar to http://dev.rubyonrails.org/ticket/10886.
I tested the Rack multipart parser with the file provided in the link and it works properly. Maybe we can base our parser from theirs?
Rack has a better solution compared to the fix in the said ticket.

Associated revisions

Revision 32469
Added by xibbar (Takeyuki Fujioka) 11 months ago

* lib/cgi/core.rb: fix multipart form parsing bug. [Bug #3866]

Revision 32469
Added by xibbar (Takeyuki Fujioka) 11 months ago

* lib/cgi/core.rb: fix multipart form parsing bug. [Bug #3866]

History

Updated by naruse (Yui NARUSE) over 1 year ago

  • Status changed from Open to Third Party's Issue
It's a problem of Rails, not Ruby.

Updated by engwan (Heinrich Lee Yu) over 1 year ago

It's not. What I am referring to is the multipart parsing of cgi/core.rb

Updated by naruse (Yui NARUSE) over 1 year ago

  • Category set to lib
  • Status changed from Third Party's Issue to Assigned
  • Assignee set to xibbar (Takeyuki Fujioka)
  • ruby -v set to Ruby 1.9.2p0

Updated by ko1 (Koichi Sasada) 12 months ago

Fujioka-san, How about it?

Updated by nahi (Hiroshi Nakamura) 11 months ago

  • Assignee changed from xibbar (Takeyuki Fujioka) to nahi (Hiroshi Nakamura)
I take this since Fujioka-san must be busy for the meanwhile. Can somebody point the new location of http://dev.rubyonrails.org/ticket/10886 ? I once posted a patch related to multipart form boundary parsing (http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/37506) and it might be the same issue.

Updated by nahi (Hiroshi Nakamura) 11 months ago

  • Target version set to 1.9.3

Updated by nahi (Hiroshi Nakamura) 11 months ago

ruby-devでも救援募集です。 cgi.rbのmultipart-form周りで何か問題があるらしいんですが、参照先のRailsのチケット管理システムがなくなっている(移動した)らしく、詳細がわかりません。どなたか、コトの詳細をご存知のかた、もしくは ttp://dev.rubyonrails.org/ticket/10886 の移動先が調べられるかたはいらっしゃいませんでしょうか。 よろしくお願いします。 (以下転送) ---------- Forwarded message ---------- From: Hiroshi NAKAMURA <nakahiro@gmail.com> Date: Thu, Jun 23, 2011 at 15:53 Subject: [ruby-core:37310] [Ruby 1.9 - Bug #3866] Multipart Form Parsing bug To: ruby-core@ruby-lang.org Issue #3866 has been updated by Hiroshi NAKAMURA. Assignee changed from Takeyuki Fujioka to Hiroshi NAKAMURA I take this since Fujioka-san must be busy for the meanwhile. Can somebody point the new location of http://dev.rubyonrails.org/ticket/10886 ? I once posted a patch related to multipart form boundary parsing (http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/37506) and it might be the same issue. ---------------------------------------- Bug #3866: Multipart Form Parsing bug http://redmine.ruby-lang.org/issues/3866 Author: Heinrich Lee Yu Status: Assigned Priority: Normal Assignee: Hiroshi NAKAMURA Category: lib Target version: ruby -v: Ruby 1.9.2p0 =begin Ruby 1.9.2p0 seems to have a problem similar to http://dev.rubyonrails.org/ticket/10886. I tested the Rack multipart parser with the file provided in the link and it works properly. Maybe we can base our parser from theirs? Rack has a better solution compared to the fix in the said ticket. =end -- http://redmine.ruby-lang.org

Updated by nahi (Hiroshi Nakamura) 11 months ago

ruby-devでも救援募集です。 cgi.rbのmultipart-form周りで何か問題があるらしいんですが、参照先のRailsのチケット管理システムがなくなっている(移動した)らしく、詳細がわかりません。どなたか、コトの詳細をご存知のかた、もしくは ttp://dev.rubyonrails.org/ticket/10886 の移動先が調べられるかたはいらっしゃいませんでしょうか。 よろしくお願いします。 (以下転送) ---------- Forwarded message ---------- From: Hiroshi NAKAMURA <nakahiro@gmail.com> Date: Thu, Jun 23, 2011 at 15:53 Subject: [ruby-core:37310] [Ruby 1.9 - Bug #3866] Multipart Form Parsing bug To: ruby-core@ruby-lang.org Issue #3866 has been updated by Hiroshi NAKAMURA. Assignee changed from Takeyuki Fujioka to Hiroshi NAKAMURA I take this since Fujioka-san must be busy for the meanwhile. Can somebody point the new location of http://dev.rubyonrails.org/ticket/10886 ? I once posted a patch related to multipart form boundary parsing (http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/37506) and it might be the same issue. ---------------------------------------- Bug #3866: Multipart Form Parsing bug http://redmine.ruby-lang.org/issues/3866 Author: Heinrich Lee Yu Status: Assigned Priority: Normal Assignee: Hiroshi NAKAMURA Category: lib Target version: ruby -v: Ruby 1.9.2p0 =begin Ruby 1.9.2p0 seems to have a problem similar to http://dev.rubyonrails.org/ticket/10886. I tested the Rack multipart parser with the file provided in the link and it works properly. Maybe we can base our parser from theirs? Rack has a better solution compared to the fix in the said ticket. =end -- http://redmine.ruby-lang.org

Updated by ayokura (Yoshihiko Nagoya) 11 months ago

おはようございます。 # ruby-devはたぶん初投稿なのではじめまして。 とりあえず、何はともあれweb.archive.orgで調べたらなんかでてきました。 http://web.archive.org/web/20090523081106/http://dev.rubyonrails.org/ticket/10886 # 内容は読んでないです。 お役に立てればうれしいです。 (11/06/28 5:55), Hiroshi Nakamura wrote: > ruby-devでも救援募集です。 > > cgi.rbのmultipart-form周りで何か問題があるらしいんですが、参照先のRailsのチケット管理システムがなくなっている(移動した)らしく、詳細がわかりません。どなたか、コトの詳細をご存知のかた、もしくは > ttp://dev.rubyonrails.org/ticket/10886 の移動先が調べられるかたはいらっしゃいませんでしょうか。 > > よろしくお願いします。 > > (以下転送) > > ---------- Forwarded message ---------- > From: Hiroshi NAKAMURA <nakahiro@gmail.com> > Date: Thu, Jun 23, 2011 at 15:53 > Subject: [ruby-core:37310] [Ruby 1.9 - Bug #3866] Multipart Form Parsing bug > To: ruby-core@ruby-lang.org > > > > Issue #3866 has been updated by Hiroshi NAKAMURA. > > Assignee changed from Takeyuki Fujioka to Hiroshi NAKAMURA > > I take this since Fujioka-san must be busy for the meanwhile. > > Can somebody point the new location of > http://dev.rubyonrails.org/ticket/10886 ? I once posted a patch > related to multipart form boundary parsing > (http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/37506) and > it might be the same issue. > ---------------------------------------- > Bug #3866: Multipart Form Parsing bug > http://redmine.ruby-lang.org/issues/3866 > > Author: Heinrich Lee Yu > Status: Assigned > Priority: Normal > Assignee: Hiroshi NAKAMURA > Category: lib > Target version: > ruby -v: Ruby 1.9.2p0 > > > =begin > Ruby 1.9.2p0 seems to have a problem similar to > http://dev.rubyonrails.org/ticket/10886. > I tested the Rack multipart parser with the file provided in the link > and it works properly. Maybe we can base our parser from theirs? > Rack has a better solution compared to the fix in the said ticket. > =end > > > > -- > http://redmine.ruby-lang.org > -- 筑波大学 情報学群 情報科学類 Univ.Tsukuba , College of Information Science . 名古屋謙彦 Yoshihiko Nagoya y.nagoya@gmail.com

Updated by ayokura (Yoshihiko Nagoya) 11 months ago

おはようございます。 # ruby-devはたぶん初投稿なのではじめまして。 とりあえず、何はともあれweb.archive.orgで調べたらなんかでてきました。 http://web.archive.org/web/20090523081106/http://dev.rubyonrails.org/ticket/10886 # 内容は読んでないです。 お役に立てればうれしいです。 (11/06/28 5:55), Hiroshi Nakamura wrote: > ruby-devでも救援募集です。 > > cgi.rbのmultipart-form周りで何か問題があるらしいんですが、参照先のRailsのチケット管理システムがなくなっている(移動した)らしく、詳細がわかりません。どなたか、コトの詳細をご存知のかた、もしくは > ttp://dev.rubyonrails.org/ticket/10886 の移動先が調べられるかたはいらっしゃいませんでしょうか。 > > よろしくお願いします。 > > (以下転送) > > ---------- Forwarded message ---------- > From: Hiroshi NAKAMURA <nakahiro@gmail.com> > Date: Thu, Jun 23, 2011 at 15:53 > Subject: [ruby-core:37310] [Ruby 1.9 - Bug #3866] Multipart Form Parsing bug > To: ruby-core@ruby-lang.org > > > > Issue #3866 has been updated by Hiroshi NAKAMURA. > > Assignee changed from Takeyuki Fujioka to Hiroshi NAKAMURA > > I take this since Fujioka-san must be busy for the meanwhile. > > Can somebody point the new location of > http://dev.rubyonrails.org/ticket/10886 ? I once posted a patch > related to multipart form boundary parsing > (http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/37506) and > it might be the same issue. > ---------------------------------------- > Bug #3866: Multipart Form Parsing bug > http://redmine.ruby-lang.org/issues/3866 > > Author: Heinrich Lee Yu > Status: Assigned > Priority: Normal > Assignee: Hiroshi NAKAMURA > Category: lib > Target version: > ruby -v: Ruby 1.9.2p0 > > > =begin > Ruby 1.9.2p0 seems to have a problem similar to > http://dev.rubyonrails.org/ticket/10886. > I tested the Rack multipart parser with the file provided in the link > and it works properly. Maybe we can base our parser from theirs? > Rack has a better solution compared to the fix in the said ticket. > =end > > > > -- > http://redmine.ruby-lang.org > -- 筑波大学 情報学群 情報科学類 Univ.Tsukuba , College of Information Science . 名古屋謙彦 Yoshihiko Nagoya y.nagoya@gmail.com

Updated by nahi (Hiroshi Nakamura) 11 months ago

  • Assignee changed from nahi (Hiroshi Nakamura) to xibbar (Takeyuki Fujioka)
Fujioka-san, thanks for your response. Please handle this. Here's a ticket: http://web.archive.org/web/20090523081106/http://dev.rubyonrails.org/ticket/10886 And the patch: http://web.archive.org/web/20081015122057/http://dev.rubyonrails.org/changeset/9113 名古屋さん、ありがとうございました。助かります。

Updated by xibbar (Takeyuki Fujioka) 11 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100
This issue was solved with changeset r32469. Heinrich, thank you for reporting this issue. Your contribution to Ruby is greatly appreciated. May Ruby be with you. ---------- * lib/cgi/core.rb: fix multipart form parsing bug. [Bug #3866]

Also available in: Atom PDF