Bug #5925: Lazy initialization is not thread safe.

I think the author expected that Hash#replace is thread-safe, and it surely is in CRuby. (see rescue for double freeze)

TBLENCWWWCOMP_ = {} # :nodoc:
...
def self.encode_www_form_component(str)
  if TBLENCWWWCOMP_.empty?
    tbl = {}
    256.times do |i|
      tbl[i.chr] = '%%%02X' % i
    end
    tbl[' '] = '+'
    begin
      TBLENCWWWCOMP_.replace(tbl)
      TBLENCWWWCOMP_.freeze
    rescue
    end
  end
  ...

Someone can rewrite this with singleton.rb. Challenger?

On Tue, Jan 24, 2012 at 10:06:21AM +0900, Hiroshi Nakamura wrote: > > Issue #5925 has been updated by Hiroshi Nakamura. > > > =begin > I think the author expected that Hash#replace is thread-safe, and it surely is in CRuby. (see rescue for double freeze) > > TBLENCWWWCOMP_ = {} # :nodoc: > ... > def self.encode_www_form_component(str) > if TBLENCWWWCOMP_.empty? > tbl = {} > 256.times do |i| > tbl[i.chr] = '%%%02X' % i > end > tbl[' '] = '+' > begin > TBLENCWWWCOMP_.replace(tbl) > TBLENCWWWCOMP_.freeze > rescue > end > end > ... > > Someone can rewrite this with singleton.rb. Challenger? Why don't we just do it when the file is required? I know it adds overhead when the file is required, but that seems minimal when compared to the runtime savings. I made a patch here: https://gist.github.com/1667280 -- Aaron Patterson http://tenderlovemaking.com/

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r34364. Xuân, thank you for reporting this issue. Your contribution to Ruby is greatly appreciated. May Ruby be with you. ---------- * lib/uri/common.rb (URI.encode_www_form_component): initialize on requiring to support JRuby, which runs parallel multithreads. [ruby-core:42222] [Bug #5925] * lib/uri/common.rb (URI.decode_www_form_component): initialize on

Thanks Aaron http://remotedatabackuptips.posterous.com/