Feature #6276
closedto_h as explicit conversion to Hash
Description
Dear Matz.
We should establish #to_h as the method for explicit conversion to Hash:
- Add Hash#to_h: returns
self
for Hash, or a Hash for subclasses of Hash - Add Struct#to_h: as requested in Feature #4862 under the wrong name
- Add OpenStruct#to_h: see Feature #1400
In addition, please consider adding NilClass#to_h.
Even though you are not completely satisfied with NilClass#to_a, I use it very often. If we ever have something equivalent to the splat operator for hashes, the same hesitations will apply to nil.to_h
, but I feel it would still bring more good than problems.
Thanks
Updated by matz (Yukihiro Matsumoto) over 12 years ago
- Assignee changed from matz (Yukihiro Matsumoto) to marcandre (Marc-Andre Lafortune)
OK, accepted, include adding nil.to_h.
Marc, could you make patch and check in?
Matz.
Updated by marcandre (Marc-Andre Lafortune) over 12 years ago
Great.
I'll do it with pleasure, expect a slight delay as I'm going in vacation for 10 days.
Thanks
Updated by marcandre (Marc-Andre Lafortune) over 12 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r35339.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- hash.c: Add Hash#to_h [Feature #6276]
[rubyspec:84b7fe3f24d2]
Updated by naruse (Yui NARUSE) over 12 years ago
- Status changed from Closed to Assigned
You didn't add tests for test-all.
If you won't add them, I'll revert them.
Updated by nahi (Hiroshi Nakamura) over 12 years ago
+1 to Naruse-san. Apparently test in the same repository is a must.
Updated by naruse (Yui NARUSE) over 12 years ago
- Status changed from Assigned to Closed
This issue was solved with changeset r35383.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
Revert r35339-35343 because of no tests.