Project

General

Profile

Actions

Bug #6742

closed

Emacs compilation-shell-minor-mode misconfiguration

Added by j2petkov (Jean-Christophe Petkovich) over 11 years ago. Updated over 11 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux]
Backport:
[ruby-core:46518]

Description

In the definition of inferior-ruby-mode, compilation-shell-minor-mode is enabled before it's variables are set. The way compilation shell is written, this will cause very strange highlighting in the inferior buffer, and inconsistent and useless behaviour of next-error. A simple fix is to put the enable after the setting of those variables. After that, next-error should take you to the file/linenumber of errors listed in the inferior buffer!

Patch which fixes the issue on my box is included.


Files

inf-ruby.patch (614 Bytes) inf-ruby.patch Patch to fix the compilation-shell-minor-mode configuration j2petkov (Jean-Christophe Petkovich), 07/17/2012 02:48 AM

Related issues 1 (0 open1 closed)

Related to Ruby master - Feature #6823: Where/how should ruby-mode issues be reported?Closedmatz (Yukihiro Matsumoto)Actions

Updated by j2petkov (Jean-Christophe Petkovich) over 11 years ago

Somehow I managed to avoid including the patch file. Let's try that again.

Updated by mame (Yusuke Endoh) over 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)

Nobu, please check this.

--
Yusuke Endoh

Actions #3

Updated by nobu (Nobuyoshi Nakada) over 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38107.
Jean-Christophe, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


inf-ruby.el: fix compilation-shell-minor-mode

  • misc/inf-ruby.el (inferior-ruby-mode): fix the
    compilation-shell-minor-mode configuration. a patch by
    j2petkov (Jean-Christophe Petkovich) in [ruby-core:46518].
    [Bug #6742]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0