Project

General

Profile

Actions

Bug #6782

closed

Fix test_offset_vtbl(TestWIN32OLE_METHOD) failure with mingw x64

Added by h.shirosaki (Hiroshi Shirosaki) almost 12 years ago. Updated almost 12 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 2.0.0dev (2012-07-23 trunk 36499) [x64-mingw32]
Backport:
[ruby-core:46651]

Description

=begin

x64-mingw32 ruby has a failure in test_win32ole_method.rb.

[1752/1812] TestWIN32OLE_METHOD#test_offset_vtbl = 0.03 s
12) Failure:
test_offset_vtbl(TestWIN32OLE_METHOD) [c:/Users/hiroshi/work/ruby/test/win32ole/
test_win32ole_method.rb:117]:
<24> expected but was
<48>.

64bit condition seems not proper with mingw.

$ ruby -e "p RUBY_PLATFORM"
"x64-mingw32"

Here is the patch to fix this.

diff --git a/test/win32ole/test_win32ole_method.rb b/test/win32ole/test_win32ole_method.rb
index e4f38ea..2c24004 100644
--- a/test/win32ole/test_win32ole_method.rb
+++ b/test/win32ole/test_win32ole_method.rb
@@ -109,7 +109,7 @@ if defined?(WIN32OLE_METHOD)
end

  def is_ruby64?
  •  /mswin64|mingw64/ =~ RUBY_PLATFORM
    
  •  /mswin64|x64-mingw/ =~ RUBY_PLATFORM
    

    end

    def test_offset_vtbl

=end

Actions #1

Updated by luislavena (Luis Lavena) almost 12 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36508.
Hiroshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Fix win32ole test failure under mingw-w64 (x64-mingw32)

  • test/win32ole/test_win32ole_method.rb (is_ruby64?): Correct platform
    used to identify mingw-w64 (x64-mingw32). Patch by Hiroshi Shirosaki.
    [ruby-core:46651][Bug #6782]
Actions

Also available in: Atom PDF

Like0
Like0