Bug #8865: OptionParser acceptable bugs

• Status: Closed
• Assignee: drbrain (Eric Hodel)
• Target version: -
• ruby -v: -
• Backport: 1.9.3: DONE, 2.0.0: DONE

[drbrain (Eric Hodel)]

I have found a few bugs in OptionParser's accept feature:

Hexadecimal and binary numbers are not properly supported for Integer

OptionParser::DecimalInteger, OptionParser::OctalInteger and OptionParser::DecimalNumeric convert invalid input to 0 or nil instead of raising InvalidArgument.

The attached patch fixes the validation regular expression for handling binary and hexadecimal arguments and adds verification for DecimalInteger, OctalInteger and DecimalNumeric

[drbrain (Eric Hodel)]

• File optparse.rb.accept.2.patch optparse.rb.accept.2.patch added

Updated with patch 2 that includes tests

[drbrain (Eric Hodel)]

• File optparse.rb.accept.3.patch optparse.rb.accept.3.patch added

Here is patch 3 that uses end-of-string anchoring to ensure the entire number is bad.

[drbrain (Eric Hodel)]

• Assignee changed from nobu (Nobuyoshi Nakada) to drbrain (Eric Hodel)

From #ruby-core IRC:

19:46 nokada: drbrain: seems fine, and add tests 1234xyz fails, plz

[drbrain (Eric Hodel)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r42844.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• lib/optparse.rb: The Integer acceptable now allows binary and
  hexadecimal numbers per the documentation. [ruby-trunk - Bug #8865]

  DecimalInteger, OctalInteger, DecimalNumeric now validate their input
  before converting to a number. [ruby-trunk - Bug #8865]

• test/optparse/test_acceptable.rb: Tests for the above, tests for all
  numeric acceptables for existing behavior.

[usa (Usaku NAKAMURA)]

• Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED to 1.9.3: DONE, 2.0.0: REQUIRED

backported into ruby_1_9_3 at r44935.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 1.9.3: DONE, 2.0.0: REQUIRED to 1.9.3: DONE, 2.0.0: DONE

r42844 and r42845 were backported to ruby_2_0_0 at r45050.