General

Profile

georgebrock (George Brocklehurst)

  • Login: georgebrock
  • Registered on: 08/04/2016
  • Last sign in: 06/29/2018

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 0 2 2

Activity

06/29/2018

01:51 PM Ruby Feature #13050: Readline: expose rl_completion_quote_character variable
I'd still love to get this merged. Is there anything I can do to help get the patch accepted? georgebrock (George Brocklehurst)

12/05/2017

06:23 PM Ruby Feature #13050: Readline: expose rl_completion_quote_character variable
This has been open for a year. Is there anything I can do towards getting the patch accepted? georgebrock (George Brocklehurst)

06/07/2017

03:57 PM Ruby Feature #13050: Readline: expose rl_completion_quote_character variable
Are there any problems with applying this patch? I'm happy to make changes if something is blocking it.
Unicode support isn't going to be possible without upstream changes in Readline.
georgebrock (George Brocklehurst)

01/29/2017

01:01 AM Ruby Feature #13050: Readline: expose rl_completion_quote_character variable
I should have mentioned in my previous comment: I also tested Readline with multi-byte quote characters, and got back only the value of the first byte from `rl_completion_quote_character`.
Anything else I can do to move this forward?
georgebrock (George Brocklehurst)

12/20/2016

10:25 AM Ruby Feature #13050: Readline: expose rl_completion_quote_character variable
It looks like my original implementation is correct: Readline doesn't support multibyte quote characters.
The source code I'm looking at is here: http://git.savannah.gnu.org/cgit/readline.git/tree/complete.c
The `_rl_find_completio...
georgebrock (George Brocklehurst)

12/19/2016

10:22 AM Ruby Feature #13050: Readline: expose rl_completion_quote_character variable
Nobuyoshi Nakada wrote:
> That variable seems an `int`.
> ...
I had assumed that it was a single byte, but after reading the Readline source code more carefully it looks like it can also be code point. I'll submit an updated patch that...
georgebrock (George Brocklehurst)

12/18/2016

10:49 PM Ruby Feature #13050 (Closed): Readline: expose rl_completion_quote_character variable
This patch makes the GNU Readline variable `rl_completion_quote_character` available to Ruby users via a method called `Readline.completion_quote_character`.
`rl_completion_quote_character` returns the character used to quote the argu...
georgebrock (George Brocklehurst)

10/10/2016

11:03 PM Ruby Feature #12659: Readline: expose rl_char_is_quoted_p setting
Nobuyoshi Nakada wrote:
> Applied in changeset r56326.
Thank you!
georgebrock (George Brocklehurst)

10/02/2016

03:09 PM Ruby Feature #12659: Readline: expose rl_char_is_quoted_p setting
Robert A. Heiler wrote:
> If I understand it correctly then you provide a wrapper that is currently not part of ruby readline module yes?
> ...
Yes, that's exactly what this patch does.
Anything I can do to move this forward?
georgebrock (George Brocklehurst)

08/06/2016

01:01 AM Ruby Feature #12659 (Closed): Readline: expose rl_char_is_quoted_p setting
I maintain an interactive Git shell [1] built in Ruby, which made extensive use of the `Readline` module. We found we outgrew the functionality provided by the module, so we built our own `Gitsh::LineEditor` module using Ruby's `Readline... georgebrock (George Brocklehurst)

Also available in: Atom