General

Profile

fxn (Xavier Noria)

  • Login: fxn
  • Email: fxn@hashref.com
  • Registered on: 03/21/2010
  • Last connection: 04/10/2021

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 1 3 4

Activity

07/18/2021

09:19 AM Ruby master Feature #17881: Add a Module#const_added callback
Followup here.
Before I started working on Zeitwerk, I benchmarked whether a TP enabled on the `:class` event had a ...
fxn (Xavier Noria)

05/23/2021

12:10 PM Ruby master Feature #17881: Add a Module#const_added callback
> Would trigger on Foo::Bar = Class.new. (This one being a current limitation with TracePoint if I'm not mistaken)
C...
fxn (Xavier Noria)
07:08 AM Ruby master Feature #17881: Add a Module#const_added callback
> If I'm not mistaken, such usage could cause the TracePoint to stay active at runtime, which isn't a huge deal, but ... fxn (Xavier Noria)
05:52 AM Ruby master Feature #17881: Add a Module#const_added callback
Oh, and while Zeitwerk can disable the TracePoint, it wouldn't be able to disable `on_new_module(&block)`, at most ha... fxn (Xavier Noria)
05:36 AM Ruby master Feature #17881: Add a Module#const_added callback
Another gotcha I see is that we cannot assume `const_added` is exclusive to Zeitwerk. Users could have their own. So ... fxn (Xavier Noria)

05/22/2021

05:29 PM Ruby master Feature #17881: Add a Module#const_added callback
> If I'm not mistaken, such usage could cause the TracePoint to stay active at runtime, which isn't a huge deal, but ... fxn (Xavier Noria)
05:01 PM Ruby master Feature #17881: Add a Module#const_added callback
Let me also add something for context. @byroot knows it and probably @Eregon too, just for anybody else following.
...
fxn (Xavier Noria)
01:31 PM Ruby master Feature #17881: Add a Module#const_added callback
Thanks a lot for working on this Jean.
If we add this, Zeitwerk would be using a somewhat more "normal" API. TracePo...
fxn (Xavier Noria)

04/17/2021

08:04 AM Ruby master Feature #17753: Add Module#namespace
In my view, the way to implement the use case that matches Ruby is to go downwards.
Module has many constants, that ...
fxn (Xavier Noria)

04/13/2021

04:35 PM Ruby master Feature #17753: Add Module#namespace
BTW, you all know AS has this concept right? https://github.com/rails/rails/blob/f1e00f00295eb51a64a3008c7b1f4c4f46e9... fxn (Xavier Noria)

Also available in: Atom