Ruby Issue Tracking System

11/19/2018

06:05 PM Ruby Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+

ahorek (Pavel Rosický) wrote:
> It wasn't intentional, but I think you shouldn't depend on TCPSocket anyway.
> ...
One more comment about it if you don't mind. Internal interfaces being created for some reason, and there was a reason t... karis10 (bug reporter)

01:13 PM Ruby Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+

ahorek (Pavel Rosický) wrote:
> ok, IMAP uses Socket.tcp instead of TCPSocket, so if you patch TCPSocket directly it won't work anymore.
> ...
I understand your intentions and don't know what are you going to do next, but it's not a go... karis10 (bug reporter)

08:26 AM Ruby Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+

nobu (Nobuyoshi Nakada) wrote:
> Could you elaborate how it is broken?
Sure.
~~~ ruby
require 'net/imap'
require 'net/pop'
require 'socksify'
Socksify::debug = true
Socksify::proxy('127.0.0.1', 1080) do |_|
# in ruby 2.4... karis10 (bug reporter)

08:18 AM Ruby Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+

ahorek (Pavel Rosický) wrote:
> https://github.com/ruby/ruby/commit/5bf395f4cbd43bf64abcf6cc19daf834d2a02046#diff-4b4baaf75652a369c39b0b76e81ad54d
> ...
I was talking about this exactly change:
~~~ diff
< @sock = TCPSocket.open... karis10 (bug reporter)

11/18/2018

10:26 AM Ruby Bug #15318 (Rejected): net/imap socket backward compatibility broken in ruby 2.5+

Hi,
I use net/pop and net/imap libraries and sometimes I need my pop/imap connections to be socksified or proxified (through TCPSocket initialize method modifications: https://github.com/Shopify/socksify-ruby). Upgrading to ruby 2.5.3 f... karis10 (bug reporter)