The following script runs under 1.9.2-p290: # encoding: UTF-8 letter = '\p{L}' atext = "[#{letter}]" /#{atext}/ Under 1.9.3-preview1 it raises an exception: test.rb:6:in `<main>': invalid character propert...xaviershay (Xavier Shay)
On 1/06/11 8:17 AM, Masaya Tarui wrote: > > Issue #3924 has been updated by Masaya Tarui. > > > > Hello, > > Require performance has been imporved a little at r31875, i think. nice! It sure has.
I tried this patch and it works as expected. Here is a patch for the test case, slightly cleaned up: diff --git a/test/coverage/test_coverage.rb b/test/coverage/test_coverage.rb index ace49d3..56966b1 100644 --- a/test/coverage/test...xaviershay (Xavier Shay)
On 31/05/11 3:55 PM, Xavier Shay wrote: > Two other options that maybe you will like: > 1) store some metadata against entries in $LOADED_FEATURES to indicate > whether they have been cached. rb_ary_push will not set this, so a qu...xaviershay (Xavier Shay)
On 1/06/11 12:24 AM, Yusuke Endoh wrote: >> In addition I have addressed the following concerns from Yusuke: >> - Please use 4 space for indent, with 8 space tab. (Emacs-style) > > Your patch still seems to use 8-space (1-tab) ...xaviershay (Xavier Shay)
Argh I mangled my benchmark table. Here is a picture that is easy to read: https://img.skitch.com/20110531-qn7nukkyretiepysmytm8r1757.jpgxaviershay (Xavier Shay)
Hello, This is a long message, but I have tried to address most of the concerns with my patch. There are two sections: one for the technical detail of the patch, and one for benchmarks. = The patch I have split my patch up into a ...xaviershay (Xavier Shay)
On 30/05/11 11:55 PM, Yusuke ENDOH wrote: > Hello, > > 2011/5/30 Xavier Shay<xavier-list@rhnh.net>: >>> - Please try to minimize a patch. >>> - It would be good to use the existing code as possible as you can. >> I realis...xaviershay (Xavier Shay)
On 30/05/11 5:35 PM, Shyouhei Urabe wrote: > * I'm not sure if your code is ready for case-insensitive filesystems > like those in Windows. I'm sure you know the problem so I should > have missed something. I don't have a...xaviershay (Xavier Shay)
On 31/05/11 1:16 AM, Yusuke ENDOH wrote: > Hello, Xavier > > http://rhnh.net/2011/05/28/speeding-up-rails-startup-time > > In the above article, you said that the bottleneck is to find > $LOADED_FEATURES in linear, but I dou...xaviershay (Xavier Shay)