Hello, aycabta (aycabta .) wrote in #note-6: > I decided to stop using `system` method for E2E testing because it depends on `ruby` command. I'm sorry for the rough implementation. > ... Thank you so much! I can confirm that this in...utkarsh (Utkarsh Gupta)
utkarsh (Utkarsh Gupta) wrote: > I am clueless as to what's causing this? Weirdly enough it looks to me that ``` IRB_HISTORY stdin.write("5\nexit\n") end ``` in `test/irb/test_history.rb` (for all these tests) has no impact a...utkarsh (Utkarsh Gupta)
Hey, mame (Yusuke Endoh) wrote in #note-1: > Hi, cloud you tell us what environment (OS, distribution, version, CPU, terminal, etc.) you are using? Thanks Right, sorry for not mentioning this earlier. I am running Debian Sid. Int...utkarsh (Utkarsh Gupta)
Hello, Whilst building Ruby 2.7.2 and Ruby 3.0~preview1, I got the following test failures: ``` 1) Failure: TestIRB::TestHistory#test_history_save_1 [/<<PKGBUILDDIR>>/test/irb/test_history.rb:31]: <"exit\n"> expected but was <"...utkarsh (Utkarsh Gupta)
With #3731 and #3740 merged, this covers up the remaining part of the issues. This was discovered when one tries to create a gem with a different framework. Could be reproduced with: `bundle gem foo --ext --test=test-unit` Signed-off-by...utkarsh (Utkarsh Gupta)
In case of multiple Rake tasks, the default tasks would look something like this: `task default: [:spec, :rubocop]` Instead, they should use %i and look something like this: `task default: %i[spec rubocop]` Signed-off-by: Utkarsh Gupta...utkarsh (Utkarsh Gupta)
If the blank lines aren't used, then rubocop tries to sort them in alphabetical order within their section. Thus, adding lines so rubocop considers them as different sections and doesn't try to sort them. Signed-off-by: Utkarsh Gupta <u...utkarsh (Utkarsh Gupta)
The Gemfile wasn't properly put in the last commit. As a result, Layout/EmptyLines inspected an offense in the Gemfile. This also fixes the spec w.r.t change in the task default. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https...utkarsh (Utkarsh Gupta)
Since this PR was made because we missed checking RuboCop offenses with different flags, therefore adding tests so that all flag combinations are tested. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rub...utkarsh (Utkarsh Gupta)
The newly added specs needs to be tagged as :readline, otherwise they fail on Windows with the backtrace: `ZeroDivisionError: divided by 0`. Such issues are already being skipped on Windows. Signed-off-by: Utkarsh Gupta <utkarsh@debian...utkarsh (Utkarsh Gupta)