General

Profile

daniel_niknam (Daniel Niknam)

  • Login: daniel_niknam
  • Registered on: 08/08/2021
  • Last sign in: 08/21/2021

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 0 1 1

Activity

08/31/2021

10:06 AM Ruby Revision fafd9d28 (git): [rubygems/rubygems] Rename `Gem::PrintableUri#parsed_uri?` to `Gem::PrintableUri#valid_uri?`
https://github.com/rubygems/rubygems/commit/a5177709c9 daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision a508693f (git): [rubygems/rubygems] Remove defensive guards
https://github.com/rubygems/rubygems/commit/dba130cd80 daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision 589377fb (git): [rubygems/rubygems] Refactor `Gem::RemoteFetcher::FetchError.build` back to its initialize method
https://github.com/rubygems/rubygems/commit/21dcdd2dc5 daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision 6d883b33 (git): [rubygems/rubygems] Remove `ruby/uri` requirement
For the purpose of this class, we need to make sure the return object by `Gem::UriParser.parse_uri` method will have the following method:
- user
- user=
- password
- password=
So we can remove the the `uri` dependency and just look for... daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision d73dc8e9 (git): [rubygems/rubygems] Remove unused method
https://github.com/rubygems/rubygems/commit/3a8486794e daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision 7067005f (git): [rubygems/rubygems] Bring back the empty line that was removed previously by mistake
https://github.com/rubygems/rubygems/commit/ffb480ca7a daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision aa898b42 (git): [rubygems/rubygems] Remove @credential_redacted instance variable
https://github.com/rubygems/rubygems/commit/c3bb52eb5c daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision 4715bbf7 (git): [rubygems/rubygems] Remove returning self for `Gem::PrintableUri#parse_uri`
https://github.com/rubygems/rubygems/commit/25c99d7f9d daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision 1948ac20 (git): [rubygems/rubygems] Replacing clone with dup
https://github.com/rubygems/rubygems/commit/30f5b3c027 daniel_niknam (Daniel Niknam)
10:06 AM Ruby Revision ceba8668 (git): [rubygems/rubygems] Remove unnecessary tests
We will be passing string to this class so there is no need to be defensive about it.
https://github.com/rubygems/rubygems/commit/30bd52a977 daniel_niknam (Daniel Niknam)

Also available in: Atom