General

Profile

thomasmarshall (Thomas Marshall)

  • Login: thomasmarshall
  • Registered on: 02/04/2024
  • Last sign in: 03/02/2024

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 0 1 1

Activity

12/29/2025

02:12 PM Ruby Revision 8afd4fad (git): [ruby/prism] Add unterminated construct tests
https://github.com/ruby/prism/commit/166764f794 thomasmarshall (Thomas Marshall)
02:12 PM Ruby Revision 14fbcf0e (git): [ruby/prism] Report missing end errors at opening token
This commit adds an `expect1_opening` function that expects a token and
attaches the error to the opening token location rather than the current
position. This is useful for errors about missing closing tokens, where
we want to point to ...
thomasmarshall (Thomas Marshall)

06/06/2025

01:09 AM Ruby Revision 6839eadd (git): [rubygems/rubygems] Add tests for GitProxy#checkout
This commit adds tests to capture the current behavior of `#checkout`.
They are not exhaustive, but they cover cases cloning and fetching the
repository with different ref types. This will make it easier to change
the caching behavior in...
thomasmarshall (Thomas Marshall)
01:09 AM Ruby Revision ee55b82b (git): [rubygems/rubygems] Cache commit SHA ref revisions
If the `ref` option is a specific commit SHA, we can check to see if
it's already fetched locally. If it is, then we don't need to re-fetch
it from the remote.
The `ref` option might not be a commit SHA, so we're using the `#commit`
met...
thomasmarshall (Thomas Marshall)

10/10/2024

03:53 AM Ruby Revision 5792bd71 (git): Emit warning for other method redefinition types
This commit ensures warnings about `object_id` and `__send__` method
redefinitions are emitted for other method types such as aliases, procs,
and attr readers—anything except C functions.
thomasmarshall (Thomas Marshall)

06/25/2024

02:32 PM Ruby Revision b88ac94e (git): [rubygems/rubygems] Only validate resolution info in Bundler
This commit switches out the full gemspec validation for a partial one
which only performs resolution related checks. This will allow gem
authors to run `bundle` commands immediately after creating a new gem
with Bundler, rather than hav...
thomasmarshall (Thomas Marshall)
02:32 PM Ruby Revision 39951293 (git): [rubygems/rubygems] Add Specification#validate_for_resolution
This method validates only what is required for resolution, skipping any
irrelevant metadata validation. This will be used by Bundler instead of
doing a full validation, allowing gem authors to use `bundle` commands
immediately in newly ...
thomasmarshall (Thomas Marshall)

03/03/2024

10:43 AM Ruby Bug #20322 (Closed): rb_enc_interned_str_cstr doesn't accept null pointer for encoding
Applied in changeset commit:git|7e4b1f8e1935a10df3c41ee60ca0987d73281126.
----------
[Bug #20322] Fix rb_enc_interned_str_cstr null encoding
The documentation for `rb_enc_interned_str_cstr` notes that `enc` can be
a null pointer, but t...
thomasmarshall (Thomas Marshall)
10:43 AM Ruby Revision 7e4b1f8e (git): [Bug #20322] Fix rb_enc_interned_str_cstr null encoding
The documentation for `rb_enc_interned_str_cstr` notes that `enc` can be
a null pointer, but this currently causes a segmentation fault when
trying to autoload the encoding. This commit fixes the issue by checking
for NULL before calling...
thomasmarshall (Thomas Marshall)

03/02/2024

07:03 PM Ruby Bug #20322: rb_enc_interned_str_cstr doesn't accept null pointer for encoding
I opened a PR to fix this: https://github.com/ruby/ruby/pull/10169 thomasmarshall (Thomas Marshall)

Also available in: Atom