General

Profile

xi (Xi Wang)

  • Login: xi
  • Registered on: 07/15/2012
  • Last sign in: 04/03/2013

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 0 1 1

Activity

12/31/2012

02:01 PM Ruby Bug #7371: Fix undefined overflow checking in bigdecimal
To see how it works, try to compile the following (simplified) code with gcc 4.8. The entire function will be optimized away with "gcc -O2" (just grep "bar" in the resulting assembly code); gcc 4.7 or earlier doesn't do that.
#define...
xi (Xi Wang)

11/16/2012

05:24 PM Ruby Bug #7371 (Closed): Fix undefined overflow checking in bigdecimal
In AddExponent() at ext/bigdecimal/bigdecimal.c:3677, the overflow checks rely on signed integer overflow, which is undefined behavior in C.
SIGNED_VALUE m = e+n;
SIGNED_VALUE eb, mb;
if(e>0) {
if(n>0) {
...
xi (Xi Wang)

Also available in: Atom