General

Profile

sam.saffron (Sam Saffron)

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 9 38 47

Activity

12/29/2022

09:37 PM Ruby Bug #19278: Constructing subclasses of Data with positional arguments
Just going to be a bit more explicit here about the problem for future travelers (I know I am repeating but this is the most succinct way imo to show the issue)...
```ruby
Foo = Data.define :x
class Bar < Foo
def initialize(*args, *...
sam.saffron (Sam Saffron)

08/17/2022

08:06 AM Ruby Feature #18822: Ruby lack a proper method to percent-encode strings for URIs (RFC 3986)
@byroot,
I am not sure the name is right here:
`CGI.path_encode`
with an alias of
`CGI.params_encode`
is far more correct.
Cause as it stands:
`CGI.url_encode("https://i❤️.ws/❤️?test=❤️")` will return an incorrect result.
`C...
sam.saffron (Sam Saffron)

08/16/2022

12:34 AM Ruby Feature #18822: Ruby lack a proper method to percent-encode strings for URIs (RFC 3986)
Since we just finished working around a nightmare scenario here @byroot, I think it is rather instructive to see a real world problem
The problem:
> You get something, that is probably a URL from somewhere and need to be able to make ...
sam.saffron (Sam Saffron)

08/08/2022

07:36 AM Ruby Feature #18822: Ruby lack a proper method to percent-encode strings for URIs (RFC 3986)
+1, for context a similar issue we recently hit:
https://github.com/sporkmonger/addressable/issues/472
Turns out tons of projects these days rely on addressable for a more complete API, it would be nice only to need to lean on it in e...
sam.saffron (Sam Saffron)

01/04/2022

02:29 AM Ruby Bug #18454: YJIT slowing down key Discourse benchmarks
@k0kubun already doing 20 iterations as a warmup, so it is not likely :cry: https://github.com/discourse/discourse/blob/bbca25e875c36d3541b22c520b6d56ae6322dfbe/script/bench.rb#L192-L192
@byroot @noahgibbs this is a tough one Ruby ...
sam.saffron (Sam Saffron)

12/31/2021

12:53 AM Ruby Bug #18454 (Closed): YJIT slowing down key Discourse benchmarks

4 out of 6 key Discourse benchmarks used in: https://github.com/discourse/discourse/blob/main/script/bench.rb are slower under YJIT.
Vanilla (median) -> YJIT (median)
Categories: 47ms -> 51
Home page: 85 -> 86
Topic: 42 -> 38
...
sam.saffron (Sam Saffron)

09/28/2021

10:40 PM Ruby Feature #18229: Proposal to merge YJIT
I have a timing question, is there any chance we can land this in the next month or so, that way we will have a bit more time to test stability for 3.1?
I worry a bit pushing this into the 3.2 timeline cause it would be a full extra yea...
sam.saffron (Sam Saffron)

05/19/2021

12:21 AM Ruby Bug #17781: Resolv::DNS RequestID table allocations are never freed, causing DNS lookups to eventually hang
update... https://github.com/ruby/resolv/pull/9/files got merged. sam.saffron (Sam Saffron)

05/17/2021

04:15 AM Ruby Misc #17811: DevelopersMeeting20210521Japan
* [Bug #17781] Resolv::DNS RequestID table allocations are never freed, causing DNS lookups to eventually hang
* Security issue is quite severe (can cause denial of service), any chance we can do a 2.7.4 release shortly?
sam.saffron (Sam Saffron)

05/11/2021

10:23 PM Ruby Feature #17837: Add support for Regexp timeouts
An alternative may be something like:
`Thread.safe_raise` which allows for raising in places we consider "safe" like mid-regex. Not sure...
sam.saffron (Sam Saffron)

Also available in: Atom