General

Profile

sam.saffron (Sam Saffron)

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 11 32 43

Activity

09/28/2020

12:07 AM Ruby master Bug #15661: Disallow concurrent Dir.chdir with block
I guess my bigger point here is that even with this fix the block form remains unsafe under concurrent use. At best t... sam.saffron (Sam Saffron)

09/26/2020

11:27 AM Ruby master Bug #15661: Disallow concurrent Dir.chdir with block
I am not sure about this, we are already misleading people a lot with the block form. I wonder if the correct long te... sam.saffron (Sam Saffron)

06/25/2020

08:09 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
Understood Jeremy, there are always compromises.
```
def bar(a:); end
def foo(*args); bar(*args); end;
```
...
sam.saffron (Sam Saffron)

06/23/2020

05:00 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
> In terms of usability, matz seems to like handling *args, **kwargs because it is explicit and not so complex.
T...
sam.saffron (Sam Saffron)

06/19/2020

02:38 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
> Arguments#[] for shorthand of Arguments#positionals[n]
I know it is not a "purely" clean interface. But I like: ...
sam.saffron (Sam Saffron)

06/11/2020

05:52 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
I started reading through the code and it is certainly tricky, I wonder if we simply make `ruby2_keywords_hash?` off... sam.saffron (Sam Saffron)

06/05/2020

07:43 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
@jeremyevans0 yeah I can confirm `...` delegation works as expected and correctly in master.
Unfortunately the probl...
sam.saffron (Sam Saffron)

06/04/2020

03:16 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
That is relying on `Hash.ruby2_keywords_hash?` surely a long term solution for Ruby 3 can not rely on that?
At a mi...
sam.saffron (Sam Saffron)
12:42 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
@Eregon: to summarize the one point of performance that I want to address here
### Memoizing a method that has both ...
sam.saffron (Sam Saffron)

05/19/2020

03:59 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
Alternative proposal
```ruby
def bar(*args, **kwargs)
end
def foo(*args)
bar(*args)
args
end
args = foo(1, ...
sam.saffron (Sam Saffron)

Also available in: Atom