General

Profile

sam.saffron (Sam Saffron)

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 11 32 43

Activity

06/25/2020

08:09 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
Understood Jeremy, there are always compromises.
```
def bar(a:); end
def foo(*args); bar(*args); end;
```
...
sam.saffron (Sam Saffron)

06/23/2020

05:00 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
> In terms of usability, matz seems to like handling *args, **kwargs because it is explicit and not so complex.
T...
sam.saffron (Sam Saffron)

06/19/2020

02:38 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
> Arguments#[] for shorthand of Arguments#positionals[n]
I know it is not a "purely" clean interface. But I like: ...
sam.saffron (Sam Saffron)

06/11/2020

05:52 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
I started reading through the code and it is certainly tricky, I wonder if we simply make `ruby2_keywords_hash?` off... sam.saffron (Sam Saffron)

06/05/2020

07:43 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
@jeremyevans0 yeah I can confirm `...` delegation works as expected and correctly in master.
Unfortunately the probl...
sam.saffron (Sam Saffron)

06/04/2020

03:16 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
That is relying on `Hash.ruby2_keywords_hash?` surely a long term solution for Ruby 3 can not rely on that?
At a mi...
sam.saffron (Sam Saffron)
12:42 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
@Eregon: to summarize the one point of performance that I want to address here
### Memoizing a method that has both ...
sam.saffron (Sam Saffron)

05/19/2020

03:59 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
Alternative proposal
```ruby
def bar(*args, **kwargs)
end
def foo(*args)
bar(*args)
args
end
args = foo(1, ...
sam.saffron (Sam Saffron)
02:47 AM Ruby master Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
Expanded proposal:
```ruby
def foo(...args)
bar(...)
args
end
args = foo(1, 2, {1 => 2}, a: 7, b: 9)
args.c...
sam.saffron (Sam Saffron)
03:56 AM Ruby master Feature #16891: Restore Positional Argument to Keyword Conversion
> Assuming we did not remove ruby2_keywords until a equally efficient replacement exists (which I'm assuming will be ... sam.saffron (Sam Saffron)

Also available in: Atom