General

Profile

srawlins (Sam Rawlins)

Issues

open closed Total
Assigned issues 0 0 0
Reported issues 1 3 4

Activity

05/01/2025

05:54 PM Ruby Revision 3176cd69 (git): [ruby/psych] fix error in @dispatch_catch
https://github.com/ruby/psych/commit/9df5501fdc srawlins (Sam Rawlins)

05/22/2014

02:29 AM Ruby Feature #9508: Add method coverage and branch coverage metrics
Hi Yusuke, I looked into the performance issue:
* I used the mail gem specs as a slightly longer performance test. Without Coverage, the specs take 10.5 seconds. The current Coverage library increases that by 14%. My proposed changes ...
srawlins (Sam Rawlins)

05/09/2014

05:04 PM Ruby Feature #9508: Add method coverage and branch coverage metrics
Hi Yusuke, thanks for the comments! I want to first defend the Demand and Use Case. And thank you for the Review comments; I'll apply them ASAP.
## Demand in Ruby Core
I think that Ripper is inadequate for these new metrics for the...
srawlins (Sam Rawlins)

04/06/2014

06:12 AM Ruby Bug #9701: RDoc description for `String#<<` and `String#concat`
True story, in string.c:
rb_define_method(rb_cString, "concat", rb_str_concat, 1);
rb_define_method(rb_cString, "<<", rb_str_concat, 1);
srawlins (Sam Rawlins)
06:08 AM Ruby Bug #9703: Inconsistent profile output
This is due to `profile.rb`'s `:specialized_instruction => false` compile option, on [line 5](https://github.com/ruby/ruby/blob/trunk/lib/profile.rb#L5). If you comment it out, none of the three cases will show any calls to `#==`. Specia... srawlins (Sam Rawlins)

04/03/2014

04:52 AM Ruby Bug #9683: Segmentation fault when using default proc feature in ruby Hash object
Nobu, Is p466 an unreleased version? Is it ruby_2_0_0 branch? In any case, you are correct: can reproduce in 2.0.0-p451 and -353. 2.1.x seem to correctly SystemStackError.
There remains a bug in trunk (and 2.1.x), however: the first S...
srawlins (Sam Rawlins)

04/02/2014

03:50 AM Ruby Feature #9602: Logic with `Enumerable#grep`
I've updated my patch some more with Enumerable#reject and Array#reject. (Array#reject was weird... I reabsorbed `ary_reject()` into `rb_ary_reject()` and left the only use of `rb_ary_push_1()` intact. I think some of this code was very ... srawlins (Sam Rawlins)

04/01/2014

07:23 PM Ruby Bug #9683: Segmentation fault when using default proc feature in ruby Hash object
Currently, trunk act's like Eran's example: `a[1]` first results in SystemStackError, then results in segmentation fault. I've tracked the segfault down to vm.c, in `vm_exec()`:
1327 vm_loop_start:
1328 result = vm_exe...
srawlins (Sam Rawlins)

03/27/2014

07:03 PM Ruby Bug #9680: String#sub and siblings should not use regex when String pattern is passed
Good point, Benoit! This is actually why I started looking into #gsub in the first place. I benchmarked ActiveSupport::Inflector [1], which does operations like `gsub!('/', '::')` and `gsub('::', '/')`. Here are the benchmarks, before an... srawlins (Sam Rawlins)
02:02 AM Ruby Bug #9680: String#sub and siblings should not use regex when String pattern is passed
I think the speedup in this patch comes almost entirely from skipping the regex engine, not from the GC savings.
Preserving `$&` (and `$~` and friends) while still not firing up the regex engine might be possible (constructing the bas...
srawlins (Sam Rawlins)

Also available in: Atom