Just to throw another voice in the ring, we've adopted a Contributor Covenant based Code of Conduct on Rails. I've also done so on every other project that I maintain, and am in favor of doing so here. Any change which makes people feel ...seantheprogrammer (Sean Griffin)
I've tried to create an isolated script to reproduce the problem, but haven't been able to thus far. I'll keep seeing if I can, but at the moment it appears to be a weird interaction between the code linked and the rest of rails.seantheprogrammer (Sean Griffin)
There is a typo in the `method_missing` definition which is the cause here. Changing `attribute_defintion` to `attribute_definition` fixes it, so the bug appears to have something to do with a `method_missing` invocation when it's define...seantheprogrammer (Sean Griffin)
The code changes https://github.com/sgrif/rails/commit/ddbed0040f5e99a751b130de8213f7cc7e0d155d cause a segfault when running the test case in `activemodel/test/cases/validations/acceptance_validations_test`. The code to reproduce is on ...seantheprogrammer (Sean Griffin)
Just to be clear, are you saying you would prefer that I edit the patch so that the methods are named #transform_keys and #transform_values?seantheprogrammer (Sean Griffin)
It looks like this bug still exists in 2.2.1, and was only fixed when splatting a hash literal. The following code is still broken: ~~~ruby def foo end h = {} foo(**h) ~~~seantheprogrammer (Sean Griffin)
When keyword args are passed to a method with splat, and there are no keyword args, an empty hash is sent. I would expect no argument to be given, same as splat with an empty array. For example: ```ruby def foo end foo(**{}) ```...seantheprogrammer (Sean Griffin)
seantheprogrammer (Sean Griffin)03:11 AM Ruby Feature #12039: Fixnum#infinite?/Bignum#infinite or Numeric#infinte, consistent with Float#infinite? and BigDecimal#infinite?