tduehr (Timur Duehr)
- Login: tduehr
- Email: tduehr@gmail.com
- Registered on: 09/16/2014
- Last sign in: 10/07/2014
Issues
| open | closed | Total | |
|---|---|---|---|
| Assigned issues | 0 | 0 | 0 |
| Reported issues | 0 | 1 | 1 |
Activity
10/08/2014
-
04:16 PM Ruby Bug #10248: Possible missing test or bug for Module#include and Module#prepend
- I've created a patch to the MRI test suite used in JRuby to check for this behavior.
https://github.com/tduehr/jruby/commit/5bf0da4e4fff1a9e122ff427ff34586025db9955
I'm now using #9112 for discussion on new behavior with a patch to... -
- Thanks for the input. I think that's enough that I can start working on it.
Porting the implementation I have for JRuby would yield O(N) method search time with recursion up to the deepest include/prepend. I'm pretty sure the current ... -
- Are you just looking for the following test to pass then for 2?
~~~
def test_simple_include
obj = Object.new
class << obj
class A; def foo; 1; end; end
module B; end
class C < A; include B; def bar; f...
10/07/2014
-
- I understand 1. I'm missing something on 2. Does that mean my example code above should raise on including `m2`?
-
- I'm working on a patch for this to use a live tree for module ancestry. I had already implemented this as part of Module#prepend before coming across this discussion. I wrote a test for this behavior as a starting point but it fails unde...
09/17/2014
-
- Ahh... just found it. https://bugs.ruby-lang.org/issues/9112
Thanks -
- Nobuyoshi Nakada wrote:
> It's a TODO, which should be fixed in the future, and there are some related tickets.
Is that to change the behavior or add the tests?
09/16/2014
-
- I've been implementing Module#prepend for JRuby. I ran into this test https://github.com/jruby/jruby/blob/master/test/jruby/test_method_cache.rb#L19
This was unexpected behavior for me. I've looked through both the MRI and rubyspec te...