Ruby Issue Tracking System

08/21/2015

01:31 AM Ruby Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value

Here is my fix.
I also created a pull request:
https://github.com/ruby/ruby/pull/1005 helfper (Helder Pereira)

08/20/2015

10:30 PM Ruby Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value

Yes, I was wrong. I missed this check in "nmin_filter":
~~~
if (data->curlen <= data->n)
return;
~~~
Which means that your patch will never execute the "nmin_filter" (that is where the bug lays) until it is called in... helfper (Helder Pereira)

09:30 PM Ruby Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value

I suppose I found the problem. Taking the first example:
~~~
[20, 32, 32, 21, 30, 25, 29, 13, 14].min(2)
~~~
This will call the function "nmin_run" in the file "enum.c", which sets "bufmax" to 4 times the number of minimums (n) w... helfper (Helder Pereira)

09:24 PM Ruby Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value

Leo Correa, I think your patch will fail for this example:
~~~
[2, 4, 8, 6, 7].min(4) #=> [2, 4, 6, 8]
~~~ helfper (Helder Pereira)