Project

General

Profile

Feature #12490 ยป remove-shadowing-warning.patch

soutaro (Soutaro Matsumoto), 06/15/2016 02:43 AM

View differences:

parse.y
yyerror("duplicated argument name");
}
else if (dvar_defined_get(name) || local_id(name)) {
rb_warning1("shadowing outer local variable - %"PRIsWARN, rb_id2str(name));
vtable_add(lvtbl->vars, name);
if (lvtbl->used) {
vtable_add(lvtbl->used, (ID)ruby_sourceline | LVAR_USED);
test/lib/test/unit/assertions.rb
assert_warning(*args) {$VERBOSE = false; yield}
end
def assert_no_warning(pat, msg = nil)
stderr = EnvUtil.verbose_warning {
EnvUtil.with_default_internal(pat.encoding) {
yield
}
}
msg = message(msg) {diff pat, stderr}
refute(pat === stderr, msg)
end
def assert_no_memory_leak(args, prepare, code, message=nil, limit: 2.0, rss: false, **opt)
require_relative '../../memory_status'
raise MiniTest::Skip, "unsupported platform" unless defined?(Memory::Status)
test/ripper/test_parser_events.rb
assert_equal("`$' without identifiers is not allowed as a global variable name", compile_error('$'))
end
def test_warning_shadowing
fmt, *args = warning("x = 1; tap {|;x|}")
assert_match(/shadowing outer local variable/, fmt)
assert_equal("x", args[0])
assert_match(/x/, fmt % args)
end
def test_warning_ignored_magic_comment
fmt, *args = warning("1; #-*- frozen-string-literal: true -*-")
assert_match(/ignored after any tokens/, fmt)
test/ruby/test_parse.rb
assert_equal(expected, actual, bug5614)
end
def test_shadowing_variable
assert_warning(/shadowing outer local variable/) {eval("a=1; tap {|a|}")}
a = "\u{3042}"
assert_warning(/#{a}/o) {eval("#{a}=1; tap {|#{a}|}")}
def test_no_shadowing_variable_warning
assert_no_warning(/shadowing outer local variable/) {eval("a=1; tap {|a|}")}
end
def test_unused_variable
test/ruby/test_rubyoptions.rb
assert_in_out_err(["-w", "-"], "eval('a=1')", [], [], feature7730)
end
def test_shadowing_variable
bug4130 = '[ruby-dev:42718]'
assert_in_out_err(["-we", "def foo\n"" a=1\n"" 1.times do |a| end\n"" a\n""end"],
"", [], ["-e:3: warning: shadowing outer local variable - a"], bug4130)
assert_in_out_err(["-we", "def foo\n"" a=1\n"" 1.times do |a| end\n""end"],
"", [],
["-e:3: warning: shadowing outer local variable - a",
"-e:2: warning: assigned but unused variable - a",
], bug4130)
feature6693 = '[ruby-core:46160]'
assert_in_out_err(["-we", "def foo\n"" _a=1\n"" 1.times do |_a| end\n""end"],
"", [], [], feature6693)
end
def test_script_from_stdin
begin
require 'pty'
    (1-1/1)