Project

General

Profile

Feature #10474

[PATCH 1/1] Refactoring math.c (Combined some macros into one macro)

Added by gogotanaka (Kazuki Tanaka) almost 5 years ago. Updated almost 5 years ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:66074]

Description

Hi, there.

We call Need_Float macro with RFLOAT_VALUE macro at the all time,
so we don't need to assign result of rb_to_float(x) to temporary variable.

This is main reason I combined these two macros into one macro called Get_RFloat_Value and
removed Need_Float2.

I'm not sure the name Get_RFloat_Value is best.
If you have more preferable one, let me know and I'll fix patch :)

Thanks. gogo.


Files

combine_some_macros_into_one_at_math.c.patch (7.19 KB) combine_some_macros_into_one_at_math.c.patch gogotanaka (Kazuki Tanaka), 11/04/2014 05:46 AM

History

Updated by gogotanaka (Kazuki Tanaka) almost 5 years ago

Hi, I just wanna check there is any problems? if so please feel free to ask me.

And if it seems good, I'm gonna update these three my patches.

10225
10255
10323

note: I'm not in a hurry. take your time :)

Also available in: Atom PDF