Project

General

Profile

Bug #11310

CSV::Table#to_csv should use concat not +

Added by zdennis (Zach Dennis) about 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux-gnu]
[ruby-core:69745]

Description

The current implementation of CSV::Table#to_a method uses Array#+ to which is really bad on performance. It seems like it should use Array#concat.

Relevant Github PR: https://github.com/ruby/ruby/pull/946

History

Updated by hsbt (Hiroshi SHIBATA) about 2 years ago

  • Assignee set to hsbt (Hiroshi SHIBATA)
  • Status changed from Open to Assigned

Updated by hsbt (Hiroshi SHIBATA) almost 2 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED
  • Status changed from Assigned to Closed

applied at r59657

Also available in: Atom PDF