Project

General

Profile

Bug #11935

Date.new returns inconsistent errors when passed invalid arguments

Added by CJKinni (Christopher Kinniburgh) over 3 years ago. Updated 29 days ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:72641]

Description

When passed invalid data, such as floats and nil values, the Date.new function returns a variety of results that aren't particularly easy to read and understand. The 'undefined method 'div' for nil:NilClass' is particularly unhelpful.

irb(main):002:0> Date.new(1,nil,1)
TypeError: no implicit conversion from nil to integer
irb(main):003:0> Date.new(1,1,nil)
NoMethodError: undefined method `div' for nil:NilClass
irb(main):004:0> Date.new(nil,1,1)
NoMethodError: undefined method `<' for nil:NilClass

I have attached a potential fix. It returns a more consistent set of "invalid day", "invalid month", and "invalid year" argument errors.


Files

date-new-argument-errors.patch (1.14 KB) date-new-argument-errors.patch Patch to ext/date/date_core.c from ruby 2.4.0dev CJKinni (Christopher Kinniburgh), 12/31/2015 06:01 PM

Related issues

Has duplicate Ruby master - Misc #15298: Inconsistent date errorsOpenActions

History

Updated by CJKinni (Christopher Kinniburgh) over 3 years ago

  • Tracker changed from Feature to Bug
  • Assignee changed from tadf (tadayoshi funaba) to matz (Yukihiro Matsumoto)
  • ruby -v set to 2.4.0dev
  • Backport set to 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN

Tadayoshi Funaba appears to have been gone for a year, so it's unclear who this should be assigned to.

#3

Updated by jeremyevans0 (Jeremy Evans) 30 days ago

  • Has duplicate Misc #15298: Inconsistent date errors added

Updated by jeremyevans0 (Jeremy Evans) 29 days ago

  • Assignee deleted (matz (Yukihiro Matsumoto))

I agree that we should make these errors consistent and have submitted a pull request to do so: https://github.com/ruby/date/pull/9

Also available in: Atom PDF