Project

General

Profile

Bug #15515

OpenStruct raising NoMethodError instead of ArgumentError

Added by lugray (Lisa Ugray) over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.7.0dev (2019-01-07 trunk 66747) [x86_64-darwin18]
[ruby-core:90918]

Description

When an OpenStruct has some attribute foo, calling the foo method with an argument gives a no method error:

foo = OpenStruct.new(bar: 'baz')
foo.bar(0) # => NoMethodError (undefined method `bar' for #<OpenStruct bar="baz">)

This is confusing, since foo.respond_to?(:bar) # => true. I would expect:

foo = OpenStruct.new(bar: 'baz')
foo.bar(0) # => ArgumentError (wrong number of arguments (given 1, expected 0))

The included fixes this, and adjusts the arity ArgumentError for the setter to be in line with the default arity messaging too.


Files

Updated by devpolish (Nardo Nykolyszyn) over 1 year ago

Did you mean? OpenStruct

#3

Updated by lugray (Lisa Ugray) over 1 year ago

  • Description updated (diff)

Updated by lugray (Lisa Ugray) over 1 year ago

devpolish (Nardo Nykolyszyn) wrote:

Did you mean? OpenStruct

Yes, thanks, fixed.

Updated by marcandre (Marc-Andre Lafortune) over 1 year ago

  • Assignee set to marcandre (Marc-Andre Lafortune)

Sorry I missed this.

I'm positive on this patch and will commit it shortly unless there's any objection.

Updated by marcandre (Marc-Andre Lafortune) over 1 year ago

  • Status changed from Open to Closed

Merged. Thank you for your contribution!

Also available in: Atom PDF