Bug #15515: OpenStruct raising NoMethodError instead of ArgumentError

• Status: Closed
• Assignee: marcandre (Marc-Andre Lafortune)
• Target version: -
• ruby -v: ruby 2.7.0dev (2019-01-07 trunk 66747) [x86_64-darwin18]
• Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN

[lugray (Lisa Ugray)]

When an OpenStruct has some attribute foo, calling the foo method with an argument gives a no method error:

foo = OpenStruct.new(bar: 'baz')
foo.bar(0) # => NoMethodError (undefined method `bar' for #<OpenStruct bar="baz">)

This is confusing, since foo.respond_to?(:bar) # => true. I would expect:

foo = OpenStruct.new(bar: 'baz')
foo.bar(0) # => ArgumentError (wrong number of arguments (given 1, expected 0))

The included fixes this, and adjusts the arity ArgumentError for the setter to be in line with the default arity messaging too.

[lugray (Lisa Ugray)]

• File 0001-ostruct.rb-refine-arity-failure-message.patch 0001-ostruct.rb-refine-arity-failure-message.patch added

[devpolish (Nardo Nykolyszyn)]

Did you mean? OpenStruct

[lugray (Lisa Ugray)]

• Description updated (diff)

[lugray (Lisa Ugray)]

devpolish (Nardo Nykolyszyn) wrote:

Did you mean? OpenStruct

Yes, thanks, fixed.

[marcandre (Marc-Andre Lafortune)]

• Assignee set to marcandre (Marc-Andre Lafortune)

Sorry I missed this.

I'm positive on this patch and will commit it shortly unless there's any objection.

[marcandre (Marc-Andre Lafortune)]

• Status changed from Open to Closed

Merged. Thank you for your contribution!