total_timeout for Net::HTTP
Net::HTTP allows setting
read_timeout, but sometimes I just want to make sure an API call will finish within a set amount of time, and am not concerned with how long opening the connection takes and reading the connection takes individually, as long as the total is beneath a certain amount. Yes, one could set
read_timeout to be equal to the maximum time they are willing to wait, but then for example if opening the socket happens almost immediately, I may get a read timeout when I am still willing to wait a bit longer (this is the case for the service I run, where we hit an external API that occasionally takes 60s to respond, and am trying to catch some of those longer running requests. it also occasionally takes over 5 seconds to open a connection, so I can't make open_timeout minimal either). In other languages, setting a total timeout is possible, like for example Java's
My intern LevonAr (Levon Arabyan ) is willing to work on this, and put in a
total_timeout option in a way that doesn't interfere with the current functioning of open_timeout and read_timeout. Would a patch to put in this feature be accepted?
Updated by prajjwal (Prajjwal Singh) over 1 year ago
+1. This is something I'd love to see implemented because this is actually the most common use case for me.
Could be implemented in a backwards compatible way (set
total_timeout and abort appropriately).