Misc #20201: Should `opt_reverse` be renamed?

• Status: Rejected
• Assignee: -

[kddnewton (Kevin Newton)]

When you use keywords with the &&= or ||= operator on a [] method call, it uses the opt_reverse instruction. For example:

h[foo: 1] &&= 2

This instruction is used regardless of if optimizations are on or off. (--dump=insns_without_opt and RubyVM::InstructionSequence.compile_option = false both don't turn it off.) eopt_reverse is also used within the peephole optimizer, so its naming makes sense in those cases.

Should the instruction be renamed reverse/stack_reverse?

[kddnewton (Kevin Newton)]

• Status changed from Open to Rejected