Misc #22006
closed
Usage of deprecated input in gem sync workflows
Description
create-github-app-token deprecated app-id in favor of client-id in https://github.com/actions/create-github-app-token/releases/tag/v3.1.0.
Since it will probably be removed in the next major version, all workflow files need to be updated eventually.
I also noticed that convictional/trigger-workflow-and-wait has been archived (https://github.com/convictional/trigger-workflow-and-wait). This shouldn't matter much, it is docker-based and should continue to work for a long time unless github does some API change.
But this made me think that perhaps this mechanism should be a composite action or something similar? Then you don't need to update it in so many places (currently 47) when something changes.
Updated by k0kubun (Takashi Kokubun) about 1 month ago
ยท Edited
But this made me think that perhaps this mechanism should be a composite action or something similar? Then you don't need to update it in so many places (currently 47) when something changes.
I'm not sure what you're proposing. The main work is already delegated to ruby/ruby through workflow_dispatch, which is kind of a composite action already, and most of the changes should not happen in 47 different places. I don't know when app-id will be dropped but the interface of workflow communication shouldn't be that unstable, so updating 47 places when that happens seems acceptable to me.
Updated by Earlopain (Earlopain _) about 1 month ago
- Status changed from Open to Closed
I guess maybe the appid needs to change some day, or the wait for workflow breaks (unlikely in the near future). I just thought it could be nice to have that all bundled in a central place.
Anyways, I'm not the one that does all the updating and if you don't see any value then you can just see this as a notification that one of the actions will change eventually.
Updated by k0kubun (Takashi Kokubun) about 1 month ago
Again, I was not sure what you were proposing from reading your description, but I think we could define a shared action that just calls "Create GitHub App token" and "Sync to ruby/ruby". We still have to make sure credentials are available for all these repos, but it's nice to improve the rest of the places regardless.