Bug #3704

openssl: exception message wording improvement

Added by Paul Betteridge over 3 years ago. Updated almost 3 years ago.

[ruby-core:31748]
Status:Closed
Priority:Normal
Assignee:Hiroshi Nakamura
Category:-
Target version:1.9.3
ruby -v:1.9.1p376 Backport:

Description

=begin
When a new connection is created, the hostname of the target is checked against the name in the certificate. If they do not match, an exception is raised. The wording of the message is not quite correct English.

It currently reads: "hostname was not match with the server certificate"

I suggest that it would be better if it read: "hostname does not match the server certificate", but if a smaller change were desired, it could be changed to "hostname was not matched with the server certificate".

This message appears in http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/ext/openssl/lib/openssl/ssl-internal.rb?revision=25189&view=markup

A patch against the trunk with my suggested wording is attached
=end

ruby-openssl-msg.patch Magnifier - proposed patch against trunk (579 Bytes) Paul Betteridge, 08/18/2010 01:10 AM

Associated revisions

Revision 29189
Added by Hiroshi Nakamura over 3 years ago

  • Fixed exception message for SSL post connection check failure. Patch by Paul Betteridge. ref [Bug #3704]

History

#1 Updated by Hiroshi Nakamura over 3 years ago

  • Assignee set to Hiroshi Nakamura

=begin

=end

#2 Updated by Hiroshi Nakamura over 3 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r29189.
Paul, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

#3 Updated by Hiroshi Nakamura over 3 years ago

=begin
Paul, I applied the patch as-is. Thanks!
=end

#4 Updated by Hiroshi Nakamura over 3 years ago

  • Target version set to 1.9.3

=begin

=end

Also available in: Atom PDF