Bug #4337

rubygems calls chdir directly, actions should be enclosed in a block

Added by Pierre-Yves Ritschard about 3 years ago. Updated almost 3 years ago.

[ruby-core:34940]
Status:Closed
Priority:Normal
Assignee:Eric Hodel
Category:lib
Target version:1.9.3
ruby -v:ruby 1.9.2p136 Backport:

Description

=begin
When installing gems, windowsstubscript is called in installer.rb which
directly calls Dir.chdir.

If this were to be called inside another Dir.chdir call with a block passed to
it, it would spew warnings.

Instead the proposed patch encloses the actions in a block, removing the need
for saving and restoring a path around the chdir call.
=end

ruby-1.9-clean-chdir.patch Magnifier (1.1 KB) Pierre-Yves Ritschard, 01/29/2011 01:44 AM

History

#1 Updated by Eric Hodel about 3 years ago

  • Status changed from Open to Closed
  • Assignee set to Eric Hodel
  • Target version set to 1.9.3

=begin
Unfortunately your supplied patch did not pass the tests.

I committed a different version which allowed the tests to pass to rubygems trunk. It will be imported when RubyGems 1.5 is released at the end of January.
=end

#2 Updated by Eric Hodel about 3 years ago

=begin
This should be fixed in trunk now as well, please verify.
=end

Also available in: Atom PDF