Bug #4337

rubygems calls chdir directly, actions should be enclosed in a block

Added by pyr (Pierre-Yves Ritschard) over 7 years ago. Updated about 7 years ago.

Target version:
ruby -v:
ruby 1.9.2p136


When installing gems, windows_stub_script is called in installer.rb which
directly calls Dir.chdir.

If this were to be called inside another Dir.chdir call with a block passed to
it, it would spew warnings.

Instead the proposed patch encloses the actions in a block, removing the need
for saving and restoring a path around the chdir call.

ruby-1.9-clean-chdir.patch (1.1 KB) ruby-1.9-clean-chdir.patch pyr (Pierre-Yves Ritschard), 01/29/2011 01:44 AM


#1 Updated by drbrain (Eric Hodel) over 7 years ago

  • Status changed from Open to Closed
  • Assignee set to drbrain (Eric Hodel)
  • Target version set to 1.9.3

Unfortunately your supplied patch did not pass the tests.

I committed a different version which allowed the tests to pass to rubygems trunk. It will be imported when RubyGems 1.5 is released at the end of January.

#2 Updated by drbrain (Eric Hodel) over 7 years ago

This should be fixed in trunk now as well, please verify.

Also available in: Atom PDF