Project

General

Profile

Bug #4337

rubygems calls chdir directly, actions should be enclosed in a block

Added by pyr (Pierre-Yves Ritschard) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 1.9.2p136
[ruby-core:34940]

Description

=begin
When installing gems, windows_stub_script is called in installer.rb which
directly calls Dir.chdir.

If this were to be called inside another Dir.chdir call with a block passed to
it, it would spew warnings.

Instead the proposed patch encloses the actions in a block, removing the need
for saving and restoring a path around the chdir call.
=end

ruby-1.9-clean-chdir.patch (1.1 KB) ruby-1.9-clean-chdir.patch pyr (Pierre-Yves Ritschard), 01/29/2011 01:44 AM

History

#1 Updated by drbrain (Eric Hodel) over 6 years ago

  • Status changed from Open to Closed
  • Assignee set to drbrain (Eric Hodel)
  • Target version set to 1.9.3

=begin
Unfortunately your supplied patch did not pass the tests.

I committed a different version which allowed the tests to pass to rubygems trunk. It will be imported when RubyGems 1.5 is released at the end of January.
=end

#2 Updated by drbrain (Eric Hodel) over 6 years ago

=begin
This should be fixed in trunk now as well, please verify.
=end

Also available in: Atom PDF