Project

General

Profile

Bug #5946

Remove too early and unnecessary calls to heaps_increment

Added by Yura Sokolov almost 5 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
Normal
ruby -v:
ruby 2.0.0dev (2012-01-29 trunk 34394) [i686-linux]
[ruby-core:42258]

Description

Too early call in lazy_sweep slows down sweep phase, cause while loop breaks on if (has_free_object) { ... return TRUE;} .

Heap expand in gc_clear_mark_on_sweep_slots unnecessary expands number of heaps, which slows down iterations in rb_objspace_call_finalizer, and gc_marks (cause we often need to binary search heap for pointer).

Testing suit: https://gist.github.com/1702301

Before:

$ sh siege.sh
Transaction rate:         114.71 trans/sec
Transaction rate:         117.84 trans/sec
Transaction rate:         121.62 trans/sec
$ sh siege.sh
Transaction rate:         118.72 trans/sec
Transaction rate:         120.32 trans/sec
Transaction rate:         121.12 trans/sec

After:

$ sh siege.sh
Transaction rate:         121.62 trans/sec
Transaction rate:         122.12 trans/sec
Transaction rate:         123.12 trans/sec
$ sh siege.sh
Transaction rate:         123.25 trans/sec
Transaction rate:         121.94 trans/sec
Transaction rate:         123.52 trans/sec

https://github.com/ruby/ruby/pull/89

History

#1 [ruby-core:42259] Updated by Narihiro Nakamura almost 5 years ago

  • Status changed from Open to Rejected

#2 [ruby-core:42260] Updated by Yura Sokolov almost 5 years ago

Could you make a benchmark, please?

My benchmark shows 1% improvement when patch is applied to ruby-trunk and 6% after other patch, which I want to introduce today's evening/tomorow .

#3 [ruby-core:42261] Updated by Yura Sokolov almost 5 years ago

I remade benchmark. It seems that I was wrong.

Excuse me.

Also available in: Atom PDF