Project

General

Profile

Bug #672

rb_io_flush in pipe_open

Added by znz (Kazuhiro NISHIYAMA) almost 11 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
Backport:
[ruby-dev:36840]

Description

=begin
直後のrb_forkの中で
#define prefork() ( \
rb_io_flush(rb_stdout), \
rb_io_flush(rb_stderr) \
)
prefork();
としているので、pipe_openのrb_io_flushは不要なのではないでしょうか?

Index: io.c
===================================================================
--- io.c (revision 19868)
+++ io.c (working copy)
@@ -4445,8 +4445,6 @@ pipe_open(struct rb_exec_arg eargp, VAL
}
else {
fflush(stdin); /
is it really needed? */

  • rb_io_flush(rb_stdout);
  • rb_io_flush(rb_stderr); pid = rb_fork(&status, 0, 0, Qnil); if (pid == 0) { /* child */ popen_redirect(&arg); =end

History

#1

Updated by matz (Yukihiro Matsumoto) almost 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
Applied in changeset r19888.
=end

Also available in: Atom PDF