Not many people use `Hash` inclusion operators, and I doubt anyone expects them to behave consistently when `compare_by_identity` is involved. Rather than raising an exception, I think returning `nil` from `==`, `<=` and `>=` whenever ei...matz (Yukihiro Matsumoto)
I think it's good to add an offset: keyword argument to `Array#index` and `Array#rindex`, for consistency with `String#index` and `String#rindex`. As for `Array#find_index`, I think we should add `offset:` there as well, keeping it in...matz (Yukihiro Matsumoto)
After reconsideration, I think `tap_each` is a better name than `tee` for this method. `tee` is familiar to Unix users, but Python's `itertools.tee` has a very different meaning (splitting an iterator into multiple independent iterato...matz (Yukihiro Matsumoto)
The consistency argument is noted, but I have reservations about introducing `to_h` into `Hash()`. Unlike `to_ary`/`to_a` or `to_int`/`to_i`, `to_h` has an unusual property: it is defined on Enumerable and Array, but whether it suc...matz (Yukihiro Matsumoto)
Thank you for the feedback. I understand the aesthetic appeal, but "cleaner" is subjective, and the existing pattern is already idiomatic Ruby with no real cognitive overhead. More importantly, "purely additive" does not mean cost-fre...matz (Yukihiro Matsumoto)
Thank you, @eregon, for the thorough analysis and for pushing this feature forward with such persistence over the years. I have reconsidered my position. Although I approved this change, and it has been in master for a year, I now bel...matz (Yukihiro Matsumoto)
I have two concerns before we move forward. On the name AST I'm not sure `ast` is the right name. The nodes returned by Prism retain concrete information such as positions, whitespace, and comments, making them closer to a Concrete...matz (Yukihiro Matsumoto)
The warning for overlapping `\p{...}` classes should be removed. The original intent was to catch mistakes like `/[:lower:]/`, but overlapping Unicode properties are not a mistake. They are expected and intentional. A warning with no act...matz (Yukihiro Matsumoto)