Bug #6854

ruby-mode.el has radical changes in `ruby-deep-indent-paren' logic

Added by Dmitry Gutov over 4 years ago. Updated about 4 years ago.

Target version:
ruby -v:
ruby 1.9.2p290 (2011-07-09) [i386-mingw32]


The following commits make a non-backward compatible change in how `ruby-deep-indent-paren' works:

Basically, the change disables deep-indent in all types of parens in (almost?) all situations.
If disabling deep-indent was the idea, I think changing the default value of this variable to nil would be sufficient.

Personally, I adopted another approach: deep-indent is on by default, but it's disabled when the first array element/call argument is not on the same line as the paren. This is similar to how indentation works in js-mode, for example.
To implement that, I imagine we'd need to make this check in `ruby-deep-indent-paren-p' instead of (ruby-expr-beg) call.

I can make a patch that would do that, but first I'd really like to see an explanation and/or examples of what exactly the changes above were meant to accomplish.


#1 [ruby-core:50498] Updated by Nobuyoshi Nakada about 4 years ago

  • Status changed from Open to Closed

Use Emacs-bundled ruby-mode.el.

#2 [ruby-core:50907] Updated by Dmitry Gutov about 4 years ago

Use Emacs-bundled ruby-mode.el.

I'm maintaining it.

Should I stop merging changes from this ruby-mode into Emacs-bundled version?

Also available in: Atom PDF