Bug #8340

rubyzip does not save time of zipped files

Added by Thilo Opaterny 12 months ago. Updated 12 months ago.

[ruby-core:54623]
Status:Third Party's Issue
Priority:Normal
Assignee:-
Category:-
Target version:-
ruby -v:ruby 2.0.0p0 (2013-02-24) [x64-mingw32] rubyzip (0.9.9) Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN

Description

I wrote a little test

require 'zip/zip'

zipName = "test.zip"
zipFile = Zip::ZipFile.open( zipName, Zip::ZipFile::CREATE )

file = File.open( "save.rb", "rb")
puts time = Zip::DOSTime.at( file.mtime )
zipEntry = Zip::ZipEntry.new( zipName, file.path, "", "", 0, 0, Zip::ZipEntry::DEFLATED, 0, time ) // I want to keep the time
outputStream = zipFile.getoutputstream( zipEntry );
outputStream << file.read
file.close
outputStream.close

zipFile.close()

Zip::ZipFile.foreach( zipName ){ |zipEntry|
p zipEntry.name
p zipEntry.time

}

it returns

2013-04-08 21:05:20 +0200
"save.rb"
2013-04-27 22:11:36 +0200

obvious it does not keep the time.

I can fix the problem if I change line 34 of c:\win\Ruby200x64\lib\ruby\gems\2.0.0\gems\rubyzip-0.9.9\lib\zip\zipoutputstream.rb
into if entryname.kindof?(ZipEntry) or entryname.kindof?( ZipStreamableStream )
but I feel that this is not the right way to do it, because there are at least 4 other kind_of?(ZipEntry) in that lib

c:\win\Ruby200x64\lib\ruby\gems\2.0.0\gems\rubyzip-0.9.9\lib\zip\zipstreamablestream.rb
tells mee that ZipStreamableStream < DelegateClass(ZipEntry)
so I think the problem should be fixed in there. But how?

History

#1 Updated by Yui NARUSE 12 months ago

  • Status changed from Open to Third Party's Issue

Report this to rubyzip's tracker.
https://github.com/aussiegeek/rubyzip

#2 Updated by Thilo Opaterny 12 months ago

Another try to fix this is to add

def kind_of?( arg )
    super( arg ) || __getobj__.kind_of?( arg )
end

to c:\win\Ruby200x64\lib\ruby\gems\2.0.0\gems\rubyzip-0.9.9\lib\zip\zipstreamablestream.rb

Also available in: Atom PDF