Bug #9733: Rails' HashWithIndifferentAccess is incompatible with Ruby's keyword arguments - Ruby master - Ruby Issue Tracking System

Actions

Copy link

Bug #9733

closed

Rails' HashWithIndifferentAccess is incompatible with Ruby's keyword arguments

Added by vrinek (Konstantinos Karachalios) over 10 years ago. Updated over 10 years ago.

Status:

Rejected

Assignee:

Target version:

ruby -v:

2.1.1

Backport:

2.0.0: UNKNOWN, 2.1: UNKNOWN

[ruby-core:<unknown>]

Description

Origin: https://github.com/rails/rails/issues/14643

In Ruby it is possible to use a POR Hash in place of keyword arguments, making the transition between using an options = {} to keyword arguments easy.

The same is not true for HashWithIndifferentAccess and this makes it difficult to pass the params hash directly to methods with keyword arguments.

Bug test¶

require 'active_support/hash_with_indifferent_access'
require 'minitest/autorun'

def sum(a: 0, b: 0)
  a + b
end

class BugTest < MiniTest::Unit::TestCase
  def setup
    @normal_hash = {a: 18, b: 24} # just a hash
    @indiff_hash = ActiveSupport::HashWithIndifferentAccess.new(@normal_hash)
  end

  def test_ruby_hash
    assert_equal 42, sum(@normal_hash)
  end

  def test_hash_with_indifferent_access
    assert_equal 42, sum(@indiff_hash)
  end
end