+1, also I think it reads better with a space. Re #14145 the motivation to use a space was also to be clickable: https://bugs.ruby-lang.org/issues/14145#note-25 FWIW your example in the description is using older backtrace, they lo...Eregon (Benoit Daloze)
Something that's not clear (to me at least) in this ticket is why would it need to be (or should be) in core vs an external gem? Couldn't that gem use `rb_profile_frames()`, etc like pf2 / dd-trace-rb ? Seeing that you are the author o...Eregon (Benoit Daloze)
+1 Leaking Fibers through an Enumerator is quite common and relying on the GC to clean that up is pretty brittle and it also adds significant complexity on the Ruby implementation (e.g. weakref to the Fiber object). You're mentioni...Eregon (Benoit Daloze)
Thanks for the explanations. naruse (Yui NARUSE) wrote in #note-9: > In this use case, interpreting "0x" prefix is not useful It could be useful, but one could workaround that with `/0x(\h+)/` instead of `/(0x\h+)/`. Leading 0 (octal)...Eregon (Benoit Daloze)
I think returning 0 when the group isn't parseable as a number seems bad behavior. At least if I would use this method, I would expect two things of it: * It returns the Integer value of that group, without needing `Integer($N)` * I...Eregon (Benoit Daloze)
FWIW, `StringValueCStr()` already exists and checks for no `\0` bytes and implies a terminating `\0`. It still seems too risky to change `RSTRING_PTR()` to not terminate though. FWIW, TruffleRuby already has lazy substrings and alway...Eregon (Benoit Daloze)
mame (Yusuke Endoh) wrote in #note-9: > When new syntax is introduced to the Ruby master branch, the built-in `prism.c` is updated immediately. In this scenario, if we attempt to retrieve `#ast` using the node definitions from a release...Eregon (Benoit Daloze)
Right, I will make a proposal for `Ruby::SourceLocation`/`Ruby::CodeLocation` or so. I hope it can be approved quickly without taking more time.Eregon (Benoit Daloze)