Ruby Issue Tracking System

02/19/2025

05:08 PM Ruby master Revision c515da3d (git): [ruby/openssl] ssl: remove cert_store from start_server test helper

OpenSSL::SSL::SSLContext#cert_store= uses SSL_CTX_set_cert_store(). The
store is used for verifying peer certificates... rhenium (Kazuki Yamaguchi)

02/11/2025

04:42 PM Ruby master Revision 47cdf98f (git): [ruby/openssl] x509: do not check for negative return from X509_*_get_ext_count()

These functions wrap X509v3_get_ext_count(). The implementation can
never return a negative number, and this behavior... rhenium (Kazuki Yamaguchi)

04:42 PM Ruby master Revision 4ac75f6f (git): [ruby/openssl] x509name: do not check for negative return from X509_NAME_entry_count()

The function never returns a negative number.
https://github.com/ruby/openssl/commit/895ce6fdfc rhenium (Kazuki Yamaguchi)

04:42 PM Ruby master Revision dedd05e9 (git): [ruby/openssl] pkcs7: add a test case for the data content type

While it is not useful alone, it is still a valid content type. Some
methods on OpenSSL::PKCS7 are only meant to work... rhenium (Kazuki Yamaguchi)

04:42 PM Ruby master Revision 8888ad69 (git): [ruby/openssl] ossl.c: avoid using sk_*() functions with NULL

Always use explicit NULL checks before interacting with STACK_OF(*).
Even though most OpenSSL functions named sk_*() ... rhenium (Kazuki Yamaguchi)

02/09/2025

10:26 AM Ruby master Revision 64a98dec (git): [ruby/openssl] ssl: fix misuse of assert_handshake_error in tests

assert_handshake_error is useful for checking handshake failures
triggered by the peer, as the underlying socket may ... rhenium (Kazuki Yamaguchi)

10:26 AM Ruby master Revision 581dbcec (git): [ruby/openssl] ssl: prefer SSLContext#max_version= in tests

Avoid using the deprecated OpenSSL::SSL::SSLContext#ssl_version= outside
the tests specifically written for it.
http... rhenium (Kazuki Yamaguchi)

10:26 AM Ruby master Revision 7d10c22a (git): [ruby/openssl] Revert "Skip a new test when old OpenSSL"

This reverts commit https://github.com/ruby/openssl/commit/8c96a69b0d47.
This is no longer necessary since we do not... rhenium (Kazuki Yamaguchi)

10:26 AM Ruby master Revision a8b36314 (git): [ruby/openssl] ssl: fix test case test_npn_advertised_protocol_too_long

The list of NPN protocols is validated in SSLContext#setup.
The assert_handshake_error is misleading. The client is ... rhenium (Kazuki Yamaguchi)

10:26 AM Ruby master Revision 5791c93f (git): [ruby/openssl] ssl: refactor test case test_verify_mode_server_cert

Minimize the amount of code inside the assert_raise block to avoid
accidentally catching a wrong exception.
https://... rhenium (Kazuki Yamaguchi)