Project

General

Profile

Bug #10054

Net::HTTPGenericRequest sets host even if it was set before by user

Added by semenyukd (Dmitriy Semenyuk) almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]
[ruby-core:63798]

Description

# there is SSH tunnel that forwards 127.0.0.1:9293 to google.com:80
request = Net::HTTP::Post.new(URI("http://127.0.0.1:9293")).tap do |req|
  req.form_data = {q: "ruby"}
  req["Host"] = "google.com"
end

This code ignores host that was already set (it uses "#{host}:#{uri}"):

Net::HTTP.start(uri.hostname, uri.port) { |http| http.request(request) }

I encountered this bug when tried to connect to remote server using SSH tunnel (/etc/hosts isn't available to edit).

Resolution:

https://bugs.ruby-lang.org/projects/ruby-trunk/repository/entry/lib/net/http/generic_request.rb line 119

def exec(sock, ver, path)   #:nodoc: internal use only
-    if @uri
+    if @uri && !self['host']
      if @uri.port == @uri.default_port

Associated revisions

Revision 70a2eb63
Added by naruse (Yui NARUSE) almost 5 years ago

  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 47077
Added by naruse (Yui NARUSE) almost 5 years ago

  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

Revision 47077
Added by naruse (Yui NARUSE) almost 5 years ago

  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

Revision 47077
Added by naruse (Yui NARUSE) almost 5 years ago

  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

Revision 47077
Added by naruse (Yui NARUSE) almost 5 years ago

  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

Revision 47077
Added by naruse (Yui NARUSE) almost 5 years ago

  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

Revision 47077
Added by naruse (Yui NARUSE) almost 5 years ago

  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

History

Updated by naruse (Yui NARUSE) almost 5 years ago

  • Status changed from Open to Feedback

Why don't you use http_proxy?

Updated by semenyukd (Dmitriy Semenyuk) almost 5 years ago

Yui NARUSE wrote:

Why don't you use http_proxy?

I need this only for some requests (imagine database that stores URLs, headers and request bodies) so adding http_proxy makes code more difficult.

Updated by naruse (Yui NARUSE) almost 5 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

Applied in changeset r47077.


  • lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
    handle req['host'] in update_uri.

  • lib/net/http/generic_request.rb
    (Net::HTTP::GenericRequest#update_uri):
    use req['host'] if it is explicitly set. Even if URI is given,
    it is already used for the initial value of req['host'].
    Therefore overwritten value should be respected. [Bug #10054]

Also available in: Atom PDF