Project

General

Profile

Misc #10207

[PATCH cleanup] compile.c: remove needless ID2SYM/SYM2ID conversions

Added by normalperson (Eric Wong) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:64807]

Description

Needless conversions made the code harder to follow.

Will commit in a few days unless there's objections.


Files

needless-sym-id-conv.patch (15.3 KB) needless-sym-id-conv.patch normalperson (Eric Wong), 09/06/2014 04:05 AM

Updated by ko1 (Koichi Sasada) over 5 years ago

  • Status changed from Open to Closed

Sorry for overlooking this ticket.

You are right.
Before Ruby 2.0, it should be VALUE (Symbol) because it is target of GC marking.
However, now they are not target of GC marking.

Also available in: Atom PDF