Project

General

Profile

Feature #10356

[PATCH 2/2] Remove unused internal functions

Added by gogotanaka (Kazuki Tanaka) about 6 years ago. Updated about 6 years ago.

Status:
Feedback
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:65587]

Description

I wondering which is preferred, remove or comment-out.

I came to the conclusion that we can invoke such a function when the time we need come.


Files

remove_unused_func_from_math.c.patch (921 Bytes) remove_unused_func_from_math.c.patch gogotanaka (Kazuki Tanaka), 10/10/2014 03:47 AM
remove_unused_func_from_internal.h.patch (878 Bytes) remove_unused_func_from_internal.h.patch gogotanaka (Kazuki Tanaka), 10/10/2014 03:47 AM

Updated by nobu (Nobuyoshi Nakada) about 6 years ago

  • Status changed from Open to Feedback

Aren't they used in complex.c?

Updated by gogotanaka (Kazuki Tanaka) about 6 years ago

@Nobuyoshi Nakada san

I'm so sorry... I just did grep by rb_math_cos, rb_math_sin, and so on... forgot C-lang has macro.

Thank you for your time. I should learn more.

Also available in: Atom PDF