Project

General

Profile

Feature #10455

[PATCH 0/n] Combine interface for creating new matrix

Added by gogotanaka (Kazuki Tanaka) almost 5 years ago. Updated almost 5 years ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:66004]

Description

I believe we'd better reduce the number of interface for creating new matrix as much as possible.

Right now, we have 7 methods for creating new matrix,

* Matrix.[](*rows)
* Matrix.rows(rows, copy = true)
* Matrix.columns(columns)
* Matrix.build(row_count, column_count, &block)
* Matrix.row_vector(row)
* Matrix.column_vector(column)
* Matrix#new_matrix (for internal)

I know each methods has meaning for each specific way.
But I wanna combine Matrix.rows with Matrix.row_vector and
Matrix.columns with Matrix.column_vector.

I suppose only Matrix.rows and Matrix.columns is totally enough.

Matrix.row_vector(row) is equivalent Matrix.rows([row]) and
Matrix.column_vector(column) is equivalent Matrix.columns([column])

If it looks fine for you, I'll make patches.

Thanks.

History

Updated by gogotanaka (Kazuki Tanaka) almost 5 years ago

For now, I'm gonna make Matrix.row_vector(row) and Matrix.column_vector(column) deprecated.

Also available in: Atom PDF