Project

General

Profile

Bug #10649

get rid of NameError in io/console (fixed at r48982)

Added by nagachika (Tomoyuki Chikanaga) over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.1.5p272 (2014-11-06 revision 48302) [x86_64-darwin13.0]
[ruby-core:67132]

Description

IO.console raise NameError after IO.console.close.

% ruby -rio/console -ve 'IO.console.close; IO.console'
ruby 2.1.5p272 (2014-11-06 revision 48302) [x86_64-darwin13.0]
-e:1:in `console': `console' is not allowed as a constant name (NameError)
        from -e:1:in `<main>'

It was fixed at r48982 in trunk/2.2. This ticket is for backport management.

Associated revisions

Revision 6a2b4ced
Added by nagachika (Tomoyuki Chikanaga) over 4 years ago

merge revision(s) r46254,r48982,r48984: [Backport #10649]

    test/io/console/test_io_console.rb: Close FDs.

    * ext/io/console/console.c (console_dev): id_console is not a
      constant name, use rb_const_remove() to get rid of NameError.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@50126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 50126
Added by nagachika (Tomoyuki Chikanaga) over 4 years ago

merge revision(s) r46254,r48982,r48984: [Backport #10649]

test/io/console/test_io_console.rb: Close FDs.

* ext/io/console/console.c (console_dev): id_console is not a
  constant name, use rb_const_remove() to get rid of NameError.

History

#1

Updated by nagachika (Tomoyuki Chikanaga) over 4 years ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: DONTNEED to 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONTNEED

r46254, r48982 and r48984 were backported into ruby_2_1 branch at r50126.

#2

Updated by nagachika (Tomoyuki Chikanaga) over 4 years ago

r48987 and r48989 were backported into ruby_2_1 branch at r50140.
They are required to get rid of CI failures.

Also available in: Atom PDF