Project

General

Profile

Misc #11681

Refinements documentation is based on older implementation

Added by lazyatom (James Adam) over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
[ruby-core:71466]

Description

It seems that the refinements documentation hasn't been updated to reflect more recent changes to how refinements work. For example, [[[https://github.com/ruby/ruby/blob/trunk/doc/syntax/refinements.rdoc#scope]]] says "You may only activate refinements at top-level, not inside any class, module or method scope", whereas the current implementation allows activating refinements anywhere except inside methods.

I've attached one potential reworking to be more accurate, but I don't mind if it's used or not. The main thing is for it to be made correct.

update-refinements-documentation.patch (2.63 KB) update-refinements-documentation.patch lazyatom (James Adam), 11/12/2015 08:14 PM

Associated revisions

Revision 52629
Added by shugo (Shugo Maeda) over 1 year ago

* doc/syntax/refinements.rdoc: update documentation to reflect
recent changes.
[ci skip] [Misc #11681] Patch by James Adam

Revision 52629
Added by shugo (Shugo Maeda) over 1 year ago

* doc/syntax/refinements.rdoc: update documentation to reflect
recent changes.
[ci skip] [Misc #11681] Patch by James Adam

Revision 52629
Added by shugo (Shugo Maeda) over 1 year ago

* doc/syntax/refinements.rdoc: update documentation to reflect
recent changes.
[ci skip] [Misc #11681] Patch by James Adam

History

#1 [ruby-core:71518] Updated by hsbt (Hiroshi SHIBATA) over 1 year ago

  • Status changed from Open to Assigned
  • Assignee set to shugo (Shugo Maeda)

#2 [ruby-core:71604] Updated by shugo (Shugo Maeda) over 1 year ago

  • Status changed from Assigned to Closed

Merged by r52629

Also available in: Atom PDF