Bug #12680: Please backport memory leak fixes in ext/openssl

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 2.1: UNKNOWN, 2.2: REQUIRED, 2.3: DONE

[rhenium (Kazuki Yamaguchi)]

The following methods have an issue of memory leak:

• OpenSSL::X509::ExtensionFactory#create_ext
• OpenSSL::X509::ExtensionFactory#config=
• OpenSSL::X509::Extension#oid=
• OpenSSL::X509::Extension#value=
• OpenSSL::X509::Attribute#oid=
• OpenSSL::X509::Request#set_attributes, #add_attribute
• OpenSSL::X509::Revoked#set_extensions, #add_extension
• OpenSSL::PKCS12.create
• OpenSSL::PKey::EC#export
• OpenSSL::PKCS7#verify
• OpenSSL::PKCS7#add_data

They are fixed on GitHub ruby/openssl but they all exist in stable branches.

Here are the fixing commits:

https://github.com/ruby/openssl/compare/3a2840e80d275895523a526ce56e4f6e7b8f9cc4...1e30cd395b14ef46e04bdd9ab72f10067890b265

Or please use the attached patch that applies on top of ruby_2_3 branch if preferred.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.1: UNKNOWN, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: UNKNOWN, 2.2: REQUIRED, 2.3: DONE

Thank you for your great work!
The patches are applied on ruby_2_3 branch at r56018.

[rhenium (Kazuki Yamaguchi)]

nagachika-san:

I'm so sorry, the third one of the patches was broken. Could you backport this as well?

https://github.com/ruby/openssl/commit/e76f076f093efb93dabf2cb042c527500f956061

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.1: UNKNOWN, 2.2: REQUIRED, 2.3: DONE to 2.1: UNKNOWN, 2.2: REQUIRED, 2.3: REQUIRED

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.1: UNKNOWN, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: UNKNOWN, 2.2: REQUIRED, 2.3: DONE